Add thread renaming for components - #3482
Open
Nibanovic wants to merge 2 commits into
Open
Conversation
github-actions
Bot
requested review from
Juliaj,
MarqRazz,
aprotyas,
bmagyar and
erickisos
July 17, 2026 13:49
Member
|
Can we also update this line to get output to which cores is pinned? |
destogl
reviewed
Jul 17, 2026
| auto_declare<bool>("is_async", false); | ||
| auto_declare<int>("thread_priority", -100); | ||
|
|
||
| auto_declare<int>("async_parameters.thread_priority", 50); |
Member
There was a problem hiding this comment.
For others, this is added in #3481, so ignore it here!
Contributor
Author
Yeah, but that is on |
This was referenced Jul 27, 2026
Contributor
Author
Overview of related PRs:As per this comment, moved parameter declaraion to To sum up, this is the merging order:
Nice to have, on this topic:Printing CPU cores we pin threads on PR: ros-controls/realtime_tools#551 |
destogl
approved these changes
Jul 29, 2026
This was referenced Jul 30, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Note: Requires fix #3481 to be merged, so we can use async parameters on controllers properly.
Note: Requires this PR on
realtime_toolsto be merged as wellI was working on distributing ros2 control processing on different cores, and It was nice to rename the threads spawned by
async_function_handler, as we can see them more easily intopoutput.In this PR, by default we rename the thread spawned to the component name, truncated to 15 chars. Alternatively, we can give the thing a name we want.
Demo:
These are the configs for controllers/hardware and the output they produce:
This config for controllers
gives these logs:
And this config for hardware:
gives these logs:
Is this user-facing behavior change?
yes, if you muddle around with threads and real-time stuff
Did you use Generative AI?
nah