Skip to content

Add thread renaming in async function handler - #550

Merged
saikishor merged 1 commit into
ros-controls:masterfrom
b-robotized-forks:feat/thread-rename
Jul 17, 2026
Merged

Add thread renaming in async function handler#550
saikishor merged 1 commit into
ros-controls:masterfrom
b-robotized-forks:feat/thread-rename

Conversation

@Nibanovic

@Nibanovic Nibanovic commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Description

Add thread renaming capabilities in async_function_handler

  • by default, the component name truncated to 15 chars
  • otherwise, configurable from yaml, alongside other async params

Tied to ros-controls/ros2_control#3482 , look there for explanation and demo

Did you use Generative AI?

Yeah, for the windows and macOS versions of thread rename. Used Gemini Pro. Did not test those versions, though.

* by default, the component name truncated to 15 chars
* otherwise, configurable from yaml, alongside other async params
@mergify

mergify Bot commented Jul 17, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.37%. Comparing base (6d77ce1) to head (cbd87d2).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
realtime_tools/src/realtime_helpers.cpp 0.00% 9 Missing ⚠️
.../include/realtime_tools/async_function_handler.hpp 0.00% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #550      +/-   ##
==========================================
- Coverage   85.31%   84.37%   -0.95%     
==========================================
  Files          17       17              
  Lines        1410     1427      +17     
  Branches      133      138       +5     
==========================================
+ Hits         1203     1204       +1     
- Misses        120      134      +14     
- Partials       87       89       +2     
Flag Coverage Δ
unittests 84.37% <0.00%> (-0.95%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../include/realtime_tools/async_function_handler.hpp 72.35% <0.00%> (-2.42%) ⬇️
realtime_tools/src/realtime_helpers.cpp 35.45% <0.00%> (-3.16%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@saikishor
saikishor merged commit 9140f9e into ros-controls:master Jul 17, 2026
25 of 28 checks passed
@destogl destogl added backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted. labels Jul 30, 2026
@destogl
destogl deleted the feat/thread-rename branch July 30, 2026 10:01
@destogl

destogl commented Jul 30, 2026

Copy link
Copy Markdown
Member

@mergify backport jazzy kilted

@mergify

mergify Bot commented Jul 30, 2026

Copy link
Copy Markdown

backport jazzy kilted

✅ Backports have been created

Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants