Skip to content

Add thread renaming in async function handler (backport #550) - #559

Merged
christophfroehlich merged 1 commit into
kiltedfrom
mergify/bp/kilted/pr-550
Jul 30, 2026
Merged

Add thread renaming in async function handler (backport #550)#559
christophfroehlich merged 1 commit into
kiltedfrom
mergify/bp/kilted/pr-550

Conversation

@mergify

@mergify mergify Bot commented Jul 30, 2026

Copy link
Copy Markdown

Description

Add thread renaming capabilities in async_function_handler

  • by default, the component name truncated to 15 chars
  • otherwise, configurable from yaml, alongside other async params

Tied to ros-controls/ros2_control#3482 , look there for explanation and demo

Did you use Generative AI?

Yeah, for the windows and macOS versions of thread rename. Used Gemini Pro. Did not test those versions, though.


This is an automatic backport of pull request #550 done by Mergify.

@mergify

mergify Bot commented Jul 30, 2026

Copy link
Copy Markdown
Author

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.69%. Comparing base (bb65bfc) to head (346f437).

Files with missing lines Patch % Lines
realtime_tools/src/realtime_helpers.cpp 0.00% 9 Missing ⚠️
.../include/realtime_tools/async_function_handler.hpp 0.00% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           kilted     #559      +/-   ##
==========================================
- Coverage   85.64%   84.69%   -0.95%     
==========================================
  Files          17       17              
  Lines        1463     1477      +14     
  Branches      131      136       +5     
==========================================
- Hits         1253     1251       -2     
- Misses        124      138      +14     
- Partials       86       88       +2     
Flag Coverage Δ
unittests 84.69% <0.00%> (-0.95%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../include/realtime_tools/async_function_handler.hpp 72.09% <0.00%> (-2.43%) ⬇️
realtime_tools/src/realtime_helpers.cpp 35.45% <0.00%> (-3.16%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich
christophfroehlich merged commit e10bdfc into kilted Jul 30, 2026
14 checks passed
@christophfroehlich
christophfroehlich deleted the mergify/bp/kilted/pr-550 branch July 30, 2026 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants