Skip to content

Drop Python 3.8, add Python 3.13, use PEP 639 SPDX license format - #287

Merged
martinpopel merged 4 commits into
martinpopel-patch-2from
copilot/sub-pr-286
Dec 4, 2025
Merged

martinpopel merged 4 commits into
martinpopel-patch-2from
copilot/sub-pr-286

Conversation

Copilot AI commented Dec 3, 2025 •

Copy link
Copy Markdown
Contributor

Updates Python version support and modernizes the project configuration.

Changes Made

  • Python Support: Dropped Python 3.8, added Python 3.13 (requires-python = ">=3.9")
  • License Format: Changed to PEP 639 bare SPDX format (license = "Apache-2.0")
  • Build System: Updated setuptools requirement from >=64 to >=77 for PEP 639 support
  • mecab-ko: Updated dependency to >=1.0.2,<2.0.0 (now supports Apple Silicon and Python 3.12+)
  • CI Workflow:
    • Removed Python 3.8 from test matrix
    • Added Python 3.13 to test matrix
    • Removed exceptions for Apple Silicon Mac and Python 3.12 (no longer needed with mecab-ko 1.0.2+)

These changes align with the updates suggested in #283 and #284.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: martinpopel <724617+martinpopel@users.noreply.github.com>
Copilot AI changed the title [WIP] Update pyproject.toml to follow PEP 639 Fix license format for setuptools 64-76 compatibility Dec 3, 2025
Copilot AI requested a review from martinpopel December 3, 2025 15:35
@martinpopel
martinpopel marked this pull request as ready for review December 3, 2025 15:40
@martinpopel

Copy link
Copy Markdown
Collaborator

@copilot Please, drop the Python 3.8 support instead, add Python 3.13 to the tests and omit the exceptions that disabled tests on Apple Silicon Mac and Python 3.12 (as suggested in #283).

Co-authored-by: martinpopel <724617+martinpopel@users.noreply.github.com>

Copilot AI commented Dec 3, 2025 •

Copy link
Copy Markdown
Contributor Author

@copilot Please, drop the Python 3.8 support instead, add Python 3.13 to the tests and omit the exceptions that disabled tests on Apple Silicon Mac and Python 3.12 (as suggested in #283).

Done in 159d14d. Changes made:

  • Dropped Python 3.8 support (requires-python = ">=3.9")
  • Added Python 3.13 to the CI test matrix
  • Removed all exceptions for Apple Silicon Mac and Python 3.12
  • Updated mecab-ko to >=1.0.2,<2.0.0
  • Updated setuptools to >=77 for PEP 639 bare SPDX license format support

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • data.statmt.org
    • Triggering command: /usr/bin/python python -m pytest -x --ignore=test/test_mecab_ko.py (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title Fix license format for setuptools 64-76 compatibility Drop Python 3.8, add Python 3.13, use PEP 639 SPDX license format Dec 3, 2025
Copilot AI requested a review from martinpopel December 3, 2025 17:09
@martinpopel
martinpopel merged commit 9c1ef0c into martinpopel-patch-2 Dec 4, 2025
83 of 121 checks passed
@martinpopel
martinpopel deleted the copilot/sub-pr-286 branch December 8, 2025 09:46
@arkadyark-cohere

Copy link
Copy Markdown

Hi @martinpopel - thanks for this work! Would it be possible to cut a release with these changes? Without it - I'd really love to be able to bump my package depending on sacrebleu to allow 3.12, but running into dependency issues with the old mecab-python and mecab-ko versions from the more recent release.

@martinpopel

Copy link
Copy Markdown
Collaborator

@arkadyark-cohere good point, thanks. Here you go: https://pypi.org/project/sacrebleu/2.6.0/.

@arkadyark-cohere

Copy link
Copy Markdown

@martinpopel thank you so much for the quick action and response! This worked for us now,, much appreciated!

This branch was previously deployed

1 inactive deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants