Skip to content

Drop Python 3.8, add Python 3.13, use PEP 639 SPDX license format #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martinpopel merged 4 commits into from
Dec 4, 2025
Merged

Drop Python 3.8, add Python 3.13, use PEP 639 SPDX license format #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
350339e
Initial plan
Copilot Dec 3, 2025
4164dfd
Fix PEP 639 license format for older setuptools compatibility
Copilot Dec 3, 2025
159d14d
Drop Python 3.8 support, add Python 3.13, remove mecab-ko exceptions
Copilot Dec 3, 2025
40fd645
Update Python version requirement to 3.9
martinpopel Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions .github/workflows/check-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macos-13, macos-14, windows-latest]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
exclude:
- os: windows-latest
python-version: '3.12'
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
steps:
- uses: actions/checkout@v4
- name: Setup Python ${{ matrix.python-version }}
Expand All @@ -35,15 +32,8 @@ jobs:
- if: matrix.os == 'windows-latest'
name: Install Windows requirements
run: choco install wget unzip
- if: ${{ matrix.os != 'macos-14' && matrix.python-version != '3.12' }}
name: Install python dependencies
- name: Install python dependencies
run: pip install ".[dev,ja,ko]"
- # mecab-ko doesn't support Apple Silicon or Python 3.12 yet.
if: ${{ matrix.os == 'macos-14' || matrix.python-version == '3.12' }}
name: Install Python dependencies on Apple Silicon or Python 3.12
run: |
pip install ".[dev,ja]"
echo "SKIP_MECAB_KO=true" >> $GITHUB_ENV
- name: Lint with Mypy
run: mypy sacrebleu scripts test
- name: Lint with Ruff
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ $ sacrebleu -i output.detok.txt -t wmt17 -l en-de | jq -r .score

# Installation

Install the official Python module from PyPI (**Python>=3.8 only**):
Install the official Python module from PyPI (**Python>=3.9 only**):

pip install sacrebleu

Expand Down
6 changes: 3 additions & 3 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[build-system]
requires = ["setuptools>=64", "setuptools_scm>=8"]
requires = ["setuptools>=77", "setuptools_scm>=8"]
build-backend = "setuptools.build_meta"

[project]
Expand Down Expand Up @@ -37,7 +37,7 @@ classifiers = [
"Typing :: Typed",
]

requires-python = ">=3.8"
requires-python = ">=3.9"

keywords = [
"machine translation",
Expand All @@ -59,7 +59,7 @@ dependencies = [
[project.optional-dependencies]
dev = ["wheel", "pytest", "mypy", "types-tabulate", "lxml-stubs", "setuptools"]
ja = ["mecab-python3>=1.0.9,<2.0.0", "ipadic>=1.0,<2.0"]
ko = ["mecab-ko>=1.0.0,<2.0.0", "mecab-ko-dic>=1.0,<2.0"]
ko = ["mecab-ko>=1.0.2,<2.0.0", "mecab-ko-dic>=1.0,<2.0"]

[project.scripts]
sacrebleu = "sacrebleu.sacrebleu:main"
Expand Down
Loading