Skip to content

pyproject.toml follows PEP639 and allows mecab-ko<2.0.0 - #286

Closed
martinpopel wants to merge 3 commits into
masterfrom
martinpopel-patch-2
Closed

martinpopel wants to merge 3 commits into
masterfrom
martinpopel-patch-2

Conversation

@martinpopel

Copy link
Copy Markdown
Collaborator

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the project's pyproject.toml to comply with PEP 639 for license specification and relaxes the mecab-ko dependency constraint.

  • Migrates license specification from file reference to SPDX identifier format
  • Removes redundant license classifier (now redundant with SPDX identifier)
  • Allows mecab-ko versions up to (but not including) 2.0.0 instead of being capped at 1.0.2

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@martinpopel

Copy link
Copy Markdown
Collaborator Author

@copilot Why are the tests still failing with

ValueError: invalid pyproject.toml config: `project.license`.
      configuration error: `project.license` must be valid exactly by one definition (2 matches found):
      
          - keys:
              'file': {type: string}
            required: ['file']
          - keys:
              'text': {type: string}
            required: ['text']

?

Copilot AI commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

@martinpopel I've opened a new pull request, #287, to work on those changes. Once the pull request is ready, I'll request review from you.

@martinpopel

Copy link
Copy Markdown
Collaborator Author

superseded by #287

@martinpopel martinpopel closed this Dec 3, 2025

This branch was previously deployed

1 inactive deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants