Allow the full php-soap/wsdl-reader 0.x range - #69
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe Composer requirement for ChangesDependency Constraint Update
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The dependency constraint now permits wsdl-reader 0.32 and 0.33 releases while retaining existing 0.32 compatibility. No merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
73427f0 to
7c1dfff
Compare
7c1dfff to
80136cd
Compare
80136cd to
7f7c9bd
Compare
Unblocks
webmozart/assert:^2downstream, and avoids having to bump this constraint on every wsdl-reader 0.x release.php-soap/wsdl-reader0.33.0 widened itswebmozart/assertconstraint to^1.11 || ^2.0, butphp-soap/encodingpinned^0.32— which for a 0.x version means>=0.32 <0.33— so consumers ofphpro/soap-clientstill resolved to wsdl-reader 0.32 and were stuck on assert v1.Constraint is now
~0.32(>=0.32 <1.0), matching the stylephpro/soap-clientalready uses.Refs phpro/soap-client#613
Full test suite passes against wsdl-reader 0.33.0 (564 tests).