Allow the full php-soap/encoding 0.x range - #20
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe pull request broadens the ChangesDependency Constraint Update
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change allows newer 0.x versions of the development-only SOAP encoding dependency without changing production dependencies. No actionable merge-readiness risk is identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Follow-up to php-soap/encoding#69.
^0.34.0means>=0.34.0 <0.35.0for a 0.x version, so this dev requirement needs a manual bump on everyphp-soap/encodingminor.~0.34(>=0.34 <1.0) allows the whole 0.x range instead.Note
~0.34.0would not have worked — with the patch digit present,~only lets the patch rise.require-devonly, so nothing downstream is affected.Test suite passes (71 tests).
Summary by CodeRabbit