Skip to content

Allow the full php-soap/encoding 0.x range - #20

Merged
veewee merged 1 commit into
mainfrom
chore/widen-encoding-constraint
Sep 3, 2026
Merged

Allow the full php-soap/encoding 0.x range#20
veewee merged 1 commit into
mainfrom
chore/widen-encoding-constraint

Conversation

@veewee

@veewee veewee commented Sep 3, 2026

Copy link
Copy Markdown
Member

Follow-up to php-soap/encoding#69.

^0.34.0 means >=0.34.0 <0.35.0 for a 0.x version, so this dev requirement needs a manual bump on every php-soap/encoding minor. ~0.34 (>=0.34 <1.0) allows the whole 0.x range instead.

Note ~0.34.0 would not have worked — with the patch digit present, ~ only lets the patch rise.

require-dev only, so nothing downstream is affected.

Test suite passes (71 tests).

Summary by CodeRabbit

  • Chores
    • Updated development tooling constraints; no user-visible changes are included in this release.

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 5f5cd6ea-8183-43e2-912e-f4d3a01c83d0

📥 Commits

Reviewing files that changed from the base of the PR and between 18b212d and daff8cf.

📒 Files selected for processing (1)
  • composer.json

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The pull request broadens the php-soap/encoding development dependency constraint in composer.json from ^0.34.0 to ~0.34.

Changes

Dependency Constraint Update

Layer / File(s) Summary
Broaden php-soap/encoding constraint
composer.json
The development dependency constraint changes from ^0.34.0 to ~0.34.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to daff8

This change allows newer 0.x versions of the development-only SOAP encoding dependency without changing production dependencies. No actionable merge-readiness risk is identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: broadening the php-soap/encoding constraint to allow the full 0.x version range.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/widen-encoding-constraint

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@veewee
veewee merged commit a61e943 into main Sep 3, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant