Skip to content

Allow the full php-soap/psr18-attachments-middleware 0.x range - #35

Merged
veewee merged 1 commit into
php-soap:v4.xfrom
veewee:chore/widen-attachments-middleware-constraint
Sep 3, 2026
Merged

Allow the full php-soap/psr18-attachments-middleware 0.x range#35
veewee merged 1 commit into
php-soap:v4.xfrom
veewee:chore/widen-attachments-middleware-constraint

Conversation

@veewee

@veewee veewee commented Sep 3, 2026

Copy link
Copy Markdown
Member

Follow-up to php-soap/encoding#69.

^0.12 means >=0.12 <0.13 for a 0.x version, so this dev requirement needs a manual bump on every psr18-attachments-middleware minor. ~0.12 (>=0.12 <1.0) allows the whole 0.x range instead.

require-dev only, so nothing downstream is affected — this just stops the constraint from needing maintenance.

Note: I could not run the test suite locally (v4.x requires PHP >= 8.4.21, my machine has 8.4.13). CI covers it; the currently resolved version is unchanged by this edit.

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 890ac94d-6717-4cb5-a4c1-f356023e7eba

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@veewee
veewee merged commit 431104f into php-soap:v4.x Sep 3, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant