fix probe-set inclusion assertion - #12601
Open
fmalmeida wants to merge 4 commits into
Open
Conversation
mahesh-panchal
left a comment
mahesh-panchal
left a comment
Member
There was a problem hiding this comment.
Can you add nf-tests for this change please?
Contributor
Author
|
Hi @mahesh-panchal ; But also, added a new test for mimicking the pipeline scenario where we might have multiple references loaded for samples with different library types, and thus, avoid loading the reference for the mutually exclusive types. Example added is CMO with probeset frna present ... but then, module should not load it in the execution. |
fmalmeida
marked this pull request as ready for review
August 6, 2026 10:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #12600
Updating the
frnaprobes-set reference assertion.It was seen when running the
nf-core/scrnaseqpipeline test dataset, that the probe-set was still being included even though data wascmo.