Support non-Azure OpenID providers - #1158
Open
oysand wants to merge 1 commit into
Open
Conversation
This was referenced Aug 5, 2026
Contributor
Author
|
Verified end to end in the full integration suite (equinor/armada#87, green), using an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
ISAR_OPENID_CONFIG_URL, which points token validation at any OpenID Connect provider instead of Azure Entra ID — a Keycloak realm for local development and for the armada integration tests, or an operator's own issuer for a deployment outside Azure. Unset, which is the default, nothing changes.Issuer validation stays enabled either way; the expected issuer comes from the discovery document.
ISAR_OPENID_SCOPEand the twoISAR_OPENAPI_*variables keep Swagger's Authorize button offlogin.microsoftonline.com. The scheme is extracted into a factory so it can be tested without reloading the module.Also asserts that
audmust be a string, not the array form RFC 7519 permits, sincefastapi-azure-authrejects the latter with an opaque 401.Verified: 165/165 tests, mypy and ruff clean,
uv.lockunmoved. Exercised end to end in the full integration suite (equinor/armada#87, 4/4 green) with anisar-robotimage built from this branch.Merge order: this PR → isar-robot bump → equinor/flotilla#2863 + equinor/sara#456 → images published → equinor/armada#87.
Supersedes #1156, which stays open as a fallback until this set is approved.