Select the identity provider by configuration - #2863
Open
oysand wants to merge 3 commits into
Open
Conversation
This was referenced Aug 5, 2026
Contributor
Author
|
The Flotilla → ISAR hop is now verified end to end (equinor/armada#87, full suite green). From the run: followed by 9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Authentication:Provider, defaulting toEntraId. Setting it toOidcpoints both inbound token validation and outbound downstream-API token acquisition at any conformant OpenID Connect issuer — a Keycloak realm for local development and for the armada integration tests, or an operator's own issuer for a deployment outside Azure.This is not an authentication bypass: issuer, audience, signature, lifetime and role validation stay enabled under either value, only the issuer differs. What is gated is transport security — a plain HTTP authority is accepted only in
LocalandIntegrationTest, and throws at startup anywhere else.Two implementation notes worth a reviewer's attention:
ConfigureandPostConfigure.JwtBearerPostConfigureOptionsrejects an HTTP authority and runs before any post-configuration we can register, while Microsoft.Identity.Web installs itsAadIssuerValidatorduring post-configuration.IDownstreamApiresolves every bearer token throughIAuthorizationHeaderProvider, so replacing that one service covers ISAR, SARA and Pointilla. The token endpoint is read from the discovery document rather than assumed.Commit 1 is unrelated and separable:
MockSignalRServicehas a pre-existing race that fails on cleanmain(3 of 3 isolated runs). It is included because it stood between this branch and a green CI run; say the word and I will split it out.Verified: 106/106 tests,
dotnet build -warnaserrorand csharpier clean, each commit builds individually. The Flotilla → ISAR hop is proven in the full integration suite (equinor/armada#87, 4/4 green).Merge order: equinor/isar#1158 → isar-robot bump → this PR + equinor/sara#456 → images published → equinor/armada#87.
Supersedes #2856, which stays open as a fallback until this set is approved.