Skip to content

fix(snapshot): allow runtime storage directory override - #13170

Closed
dfeigin-nv wants to merge 1 commit into
pagebroker-kubernetesfrom
pagebroker-rootfs-diff
Closed

fix(snapshot): allow runtime storage directory override#13170
dfeigin-nv wants to merge 1 commit into
pagebroker-kubernetesfrom
pagebroker-rootfs-diff

Conversation

@dfeigin-nv

@dfeigin-nv dfeigin-nv commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Allows the Snapshot DaemonSet runtime storage path to be overridden.

Validation: Helm lint and render.

@dfeigin-nv
dfeigin-nv requested a review from a team as a code owner August 13, 2026 11:41
@github-actions github-actions Bot added fix deployment::k8s Relates to dynamo deployment in kubernetes labels Aug 13, 2026

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

Comment thread deploy/helm/charts/snapshot/values.yaml Outdated
@datadog-official

datadog-official Bot commented Aug 13, 2026

Copy link
Copy Markdown

Pipelines

⚠️ Warnings

🚦 3 Pipeline jobs failed

Pre Merge | pre-commit   View in Datadog   GitHub Actions

🔧 Fix in code. This looks caused by changes in this PR. Detected differences in 'deploy/snapshot/pagebroker/v1/pagebroker.proto'. Please run 'pre-commit run --all-files' and commit changes.

Docs link check | lychee   View in Datadog   GitHub Actions

See error 404 error: multiple requested URLs not found.

Pre Merge | pre-merge-status-check   View in Datadog   GitHub Actions

📋 Copy prompt for your agent
CI on my pull request is failing. Help me find and fix the root cause of each failing job below — they were flagged as caused by changes in this PR, so focus on the diff. For each job, explain the failure and propose a fix.

Branch: pagebroker-rootfs-diff

Pre Merge | pre-commit
Commit: b982ada6dc92a19e86549ae5042fb2d62c53e159
Error (code / build):
Detected differences in 'deploy/snapshot/pagebroker/v1/pagebroker.proto'. Please run 'pre-commit run --all-files' and commit changes.
CI job: https://github.com/ai-dynamo/dynamo/actions/runs/31950948371/job/95174234651

ℹ️ Info

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 46.60% (-2.14%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b982ada | Docs | Datadog PR Page | Give us feedback!

@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-rootfs-diff branch from cfefbce to d049cc0 Compare August 13, 2026 11:59
@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-rootfs-diff branch from d049cc0 to da9984a Compare August 16, 2026 08:45
@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-rootfs-diff branch from da9984a to db1a603 Compare August 16, 2026 08:51
@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-rootfs-diff branch 2 times, most recently from 11106a7 to 6a49801 Compare August 16, 2026 10:34
@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-rootfs-diff branch from 6a49801 to 8707f67 Compare August 16, 2026 11:33
@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-rootfs-diff branch from 8707f67 to ebb7f3a Compare August 16, 2026 13:29
@dfeigin-nv

Copy link
Copy Markdown
Contributor Author

Moved to ai-dynamo/snapshot#92.

@dfeigin-nv dfeigin-nv closed this Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deployment::k8s Relates to dynamo deployment in kubernetes fix size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant