Skip to content

feat(charts): mount rootfs diff for PageBroker - #92

Open
dfeigin-nv wants to merge 1 commit into
pagebroker-kubernetesfrom
pagebroker-rootfs-diff
Open

feat(charts): mount rootfs diff for PageBroker#92
dfeigin-nv wants to merge 1 commit into
pagebroker-kubernetesfrom
pagebroker-rootfs-diff

Conversation

@dfeigin-nv

@dfeigin-nv dfeigin-nv commented Aug 20, 2026

Copy link
Copy Markdown

Adds the optional rootfs-diff mount used by the PageBroker-enabled agent image.

Validation: Helm lint and render.

Summary by CodeRabbit

  • New Features
    • Added an optional setting to configure the host directory for container runtime snapshots and overlay upper directories.
    • When omitted, the appropriate default directory is selected automatically based on the container runtime.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 82efc535-99b6-4935-952b-5b869be83e92

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: ef037735-73df-4b9b-bed3-eb1d48619e6d

📥 Commits

Reviewing files that changed from the base of the PR and between 3342f11 and 6cf0834.

📒 Files selected for processing (2)
  • charts/snapshot/templates/_helpers.tpl
  • charts/snapshot/values.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 4 remain after this review.


Walkthrough

The snapshot chart now accepts runtime.storageDir. The helper uses this value when set and retains runtime-specific defaults when it is empty.

Changes

Runtime storage configuration

Layer / File(s) Summary
Storage directory override
charts/snapshot/values.yaml, charts/snapshot/templates/_helpers.tpl
The chart adds runtime.storageDir and resolves it before the existing CRI-O or containerd defaults.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 6cf08

This change adds an optional rootfs-diff mount for the PageBroker-enabled agent image; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title uses the valid feat Conventional Commit prefix, stays under 72 characters, and describes the rootfs-diff mount change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Breaking Api Changes ✅ Passed The topic diff changes no API fields, Go field types, JSON tags, or PodSnapshot immutability markers; its only api/** change adds two constants.
Rbac Least Privilege ✅ Passed The pull-request patch changes only runtime storageDir Helm values and helper logic; it adds no RBAC marker or Helm RBAC wildcard grant.

Comment @coderabbitai help to get the list of available commands.

@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-rootfs-diff branch from 2b107ad to 8c11ead Compare August 20, 2026 09:52
@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-rootfs-diff branch 2 times, most recently from 12ff3a2 to f8d36a3 Compare August 20, 2026 09:58
@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-rootfs-diff branch from f8d36a3 to cd45737 Compare August 20, 2026 10:01
@dfeigin-nv
dfeigin-nv marked this pull request as ready for review August 20, 2026 10:12
@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-rootfs-diff branch from cd45737 to afafbbb Compare August 20, 2026 10:29
@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-rootfs-diff branch from afafbbb to 1570ce8 Compare August 20, 2026 10:36
@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-rootfs-diff branch from 1570ce8 to 04aad0b Compare August 20, 2026 10:42
@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-rootfs-diff branch 2 times, most recently from 597cfa1 to bf17a28 Compare August 20, 2026 13:45
@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-rootfs-diff branch from bf17a28 to 7d8c366 Compare August 20, 2026 14:11
@dfeigin-nv

Copy link
Copy Markdown
Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
✅ Action performed

Full review finished.

@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-rootfs-diff branch from 7d8c366 to cd05a49 Compare August 20, 2026 18:05
@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-rootfs-diff branch from cd05a49 to 6cf0834 Compare August 20, 2026 18:07
@dfeigin-nv

Copy link
Copy Markdown
Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown
✅ Action performed

Full review finished.

@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-rootfs-diff branch from 6cf0834 to 52028ea Compare August 23, 2026 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant