Skip to content

feat(snapshot): complete concurrent PageBroker staging - #13172

Closed
dfeigin-nv wants to merge 10 commits into
pagebroker-imagefrom
pagebroker-daemon-concurrency
Closed

feat(snapshot): complete concurrent PageBroker staging#13172
dfeigin-nv wants to merge 10 commits into
pagebroker-imagefrom
pagebroker-daemon-concurrency

Conversation

@dfeigin-nv

@dfeigin-nv dfeigin-nv commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Adds concurrent PageBroker request handling and bounded terminal transaction retention.

Validation: make -C deploy/snapshot/pagebroker test daemon, go test ./internal/pagebroker, Helm lint/render, and git diff --check.

Concurrent restore E2E (commit c19741ace6): on aws-k3s-eu-north, namespace runai-test, two restore requests were submitted 48 ms apart. Both restore pods became Ready; PageBroker staged and committed separate transaction IDs; agent logs reported CRIU restore completion for both.

@dfeigin-nv
dfeigin-nv requested a review from a team as a code owner August 13, 2026 11:45
@github-actions github-actions Bot added the feat label Aug 13, 2026

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 4 potential issues.

View 1 additional finding in Devin Review.

Open in Devin Review

Comment thread deploy/snapshot/pagebroker/broker.cpp
Comment thread deploy/snapshot/pagebroker/broker.cpp Outdated
Comment thread deploy/snapshot/pagebroker/daemon.cpp Outdated
Comment thread deploy/snapshot/pagebroker/broker.cpp
Comment thread deploy/snapshot/pagebroker/daemon.cpp Outdated
@datadog-official

datadog-official Bot commented Aug 13, 2026

Copy link
Copy Markdown

Pipelines  Tests

⚠️ Warnings

🚦 3 Pipeline jobs failed

Pre Merge | pre-commit   View in Datadog   GitHub Actions

🔧 Fix in code. This looks caused by changes in this PR. Pre-commit hooks made changes that need to be committed.

Docs link check | lychee   View in Datadog   GitHub Actions

See error Multiple resources not found returning 404 status codes from several documentation links.

Pre Merge | pre-merge-status-check   View in Datadog   GitHub Actions

📋 Copy prompt for your agent
CI on my pull request is failing. Help me find and fix the root cause of each failing job below — they were flagged as caused by changes in this PR, so focus on the diff. For each job, explain the failure and propose a fix.

Branch: pagebroker-daemon-concurrency

Pre Merge | pre-commit
Commit: 9d1d91094e9f24fc887537f87e9471a138521fd6
Error (code / build):
Pre-commit hooks made changes that need to be committed.
CI job: https://github.com/ai-dynamo/dynamo/actions/runs/31950955588/job/95174284371

ℹ️ Info

🔄 Datadog auto-retried 3 jobs - 3 passed on retry View in Datadog

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 48.19% (-1.48%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 9d1d910 | Docs | Datadog PR Page | Give us feedback!

@dfeigin-nv
dfeigin-nv requested a review from a team as a code owner August 13, 2026 11:59
@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-daemon-concurrency branch from 66a0d19 to da9c5dc Compare August 13, 2026 11:59
@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-daemon-concurrency branch from da9c5dc to c19741a Compare August 13, 2026 12:11
Comment thread deploy/snapshot/pagebroker/broker.cpp Outdated
Comment thread deploy/snapshot/pagebroker/broker.cpp
Comment thread deploy/snapshot/pagebroker/broker.cpp
@github-actions github-actions Bot added deployment::k8s Relates to dynamo deployment in kubernetes container labels Aug 13, 2026
Comment thread deploy/snapshot/pagebroker/main.cpp Outdated
@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-daemon-concurrency branch from 6d64deb to abfc333 Compare August 13, 2026 13:07
Comment thread deploy/snapshot/internal/pagebroker/client.go Outdated
Comment thread deploy/snapshot/pagebroker/broker.cpp
@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-daemon-concurrency branch from abfc333 to 12d2935 Compare August 13, 2026 13:25
Comment thread deploy/snapshot/pagebroker/broker.cpp
@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-daemon-concurrency branch from b154343 to aa27450 Compare August 13, 2026 13:42
@dfeigin-nv

Copy link
Copy Markdown
Contributor Author

Moved to ai-dynamo/snapshot#94.

@dfeigin-nv dfeigin-nv closed this Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

container deployment::k8s Relates to dynamo deployment in kubernetes feat size/XXL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant