Repository navigation
Conversation
added 4 commits
October 13, 2026 15:48
While the world backdrop is active on the Item/Bag page, skip the MENUFORM_DTYPE_MAINFRM and MENUFORM_DTYPE_MAINIMG forms so they cannot repaint the brown retail lens over the world. Other inventory forms still draw. Include the graphics header's standard-library dependencies before the forced memcpy macro is in effect, so <filesystem> parses.
Opening the town or dungeon menu now waits for the player to stop, swings the gameplay camera to the player's front (its own collision check keeps it clear of scenery), hides the player and shadow, frames them at a fixed distance between the quick-select circles and the status bars with depth of field off, and grabs that frame. The Item pages draw the window-resolution picture of it from a texture of their own, and the live menu character through the same camera at the player's spot, so gear changes show at once. Leaving the menu makes the last shown character the world character and restores the camera. The grab's CPU image is filled as well: the menus reuse the grab texture's slot, and the texture then falls back to that image, which showed as noise. The Item menu keeps its layout inside a centred 16:9 area on wider windows (UiAnchor::max_aspect, in the Kazarov submodule). Also guards the bag form loop so the PS2 build compiles.
Points tools/kazarov at 5918d300 (TheMoonPeople/Kazarov#3), which adds UiAnchor::max_aspect; the Item menu uses it to keep its layout inside a centred 16:9 area.
Jeffiest
marked this pull request as ready for review
October 13, 2026 23:38
Member
|
Please don’t edit any source files in the ps2 directory, they shouldn’t contain port changes beyond disabling assembly that won’t compile |
Contributor
Author
|
Fixed. I dont think it will pass checks until the TheMoonPeople/Kazarov#3 is approved. |
Adubbz
pushed a commit
that referenced
this pull request
Oct 18, 2026
The town and dungeon main menus wait while the following camera frames the player: it swings to the player's front, settles against the scenery and holds a close framing with the player and shadow hidden and depth of field off. The Item page draws that frame at window resolution in place of its black fill and retail backdrop forms, and draws the menu character through the world camera at the player's spot. Other pages keep retail's grab of the world as it was when the menu was asked for. Closing the menu restores the camera and the player. The panels spread to the edges of a centred 16:9 area (UiAnchor::max_aspect); the selection frame and command popup move with their panel, a carried item is drawn at the pointer, and mouse hit tests map back to the retail layout. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Adubbz
pushed a commit
that referenced
this pull request
Oct 21, 2026
#137) #136 pinned b93a533, the head of Kazarov #27's branch. #27 was squash-merged into Kazarov master as 96c2d95, which has the same tree, so nothing in the build changes. The pin now names a commit on the branch .gitmodules follows, rather than one only kept by the pull request. Co-authored-by: carrdylan52 <17089587+carrdylan52@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pairs with TheMoonPeople/Kazarov#3 ("Inventory screen: UI anchor width limit for centred layouts"), on the same branch name (
inventory-screen-2026-10-13). This PR pins that Kazarov commit (5918d300), so it stays a draft until Kazarov#3 is merged and the pin can point at Kazarovmain.What
The Item/Bag menu no longer shows the brown retail backdrop. It shows the paused game world with the live inventory character standing in it.
UiAnchor::max_aspectfrom Kazarov#3.Testing
MenuDrawGrab.GrabRoundTripis updated for the filled CPU image.Not in this PR