Port: Item page over the paused world with the live character (#27)

The town and dungeon main menus wait while the following camera frames the
player: it swings to the player's front, settles against the scenery and holds
a close framing with the player and shadow hidden and depth of field off. The
Item page draws that frame at window resolution in place of its black fill and
retail backdrop forms, and draws the menu character through the world camera at
the player's spot. Other pages keep retail's grab of the world as it was when
the menu was asked for. Closing the menu restores the camera and the player.

The panels spread to the edges of a centred 16:9 area (UiAnchor::max_aspect);
the selection frame and command popup move with their panel, a carried item is
drawn at the pointer, and mouse hit tests map back to the retail layout.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Author: 2 people

docs/PC.md

@@ -870,6 +870,12 @@ outside the menu (1550). `item-menu-mouse-dungeon.input` reaches the dungeon's
 Item page and opens Bread's commands by frame 2850. These two scripts also use
 1280x720; scale `mouse:dx,dy` counts with the window dimensions for other sizes.
 
+### Item page over the paused world
+
+The town and dungeon main menus open over the paused world instead of the retail backdrop (`port/src/menu_world.cpp`). The request waits up to 20 ticks for the player to stop, swings the following camera to the player's front, where the next world tick's collision check keeps it clear of scenery, hides the player and its shadow, and holds the camera 89.7 units out and to the side so the player stands in the space the Item page leaves for the character. Depth of field is off from then until the menu closes. `MenuMainInit` then runs on that frame. Its `MenuCapture` keeps the frame at window resolution in a frame target of its own, while retail's half-size grab, which the other pages show, copies the world as it was when the menu was asked for, with the player and the walking camera. A subgame, the eye view, a fixed town camera, a non-following camera or the loop leaving its field mode leaves the menu as retail opens it.
+
+On the Item page the picture replaces the black fill and the retail backdrop forms. The menu character is drawn through the world camera at the player's spot, facing it; the Ridepod is drawn at 0.6 scale and the monster form at 0.8. A looked-at weapon or rod keeps the menu's close-up. Panels left of the bag board are anchored to the left edge and the rest to the right, within a centred 16:9 area (`gfx::UiAnchor::max_aspect`); the selection frame and the command popup move with their panel, a carried item is drawn at the pointer, and mouse hit tests map the pointer back to the retail layout. Closing the menu restores the camera and the player.
+
 ### Make and Monster Transform mouse
 
 On the Make menu, hovering an invention card or a cell of the item board moves

port/include/stubs/dng_main.hpp

@@ -14,3 +14,4 @@ class CActionChara;
 void PortRetailResetEyeView(CActionChara *) asm("DngMain_ResetEyeView");
 int  PortRetailChangeSetUnit(int) asm("DngMain_ChangeSetUnit");
 int  PortRetailDngMainKey() asm("DngMain_DngMainKey");
+void PortRetailDngMainDraw() asm("DngMain_DngMainDraw");

port/include/stubs/editloop.hpp

@@ -8,3 +8,4 @@ extern int PauseFlag asm("EditLoop_Pause");
 extern int ActiveCharaNo asm("EditLoop_ActiveCharaNo");
 
 void PortRetailUpdateTrBoxFlag(int map_no) asm("EditLoop_UpdateTrBoxFlag");
+int  PortRetailEditDraw() asm("EditLoop_EditDraw");

port/include/stubs/menudraw.hpp

@@ -4,3 +4,4 @@
 extern short                  use_trans_rect asm("MenuDraw_IconSheet");
 extern struct MENU_SHORT_RECT item_transtbl[2] asm("MenuDraw_IconUV");
 extern float                  MenuWakuPutXY[2] asm("MenuDraw_WakuPosition");
+void                          PortRetailDrawMenuFillBox(int, int, int, int) asm("MenuDraw_DrawMenuFillBox");

port/include/stubs/menumain.hpp

@@ -1,3 +1,6 @@
 #pragma once
 #include <menumain.hpp>
 extern CMenuInter *CMenuInterPt asm("MenuMouse_Inter");
+int                PortRetailMenuMainInit(MENU_INIT_ARG *) asm("MenuMain_MenuMainInit");
+int                PortRetailMenuMainExit() asm("MenuMain_MenuMainExit");
+void               PortRetailMenuWorldTrans() asm("MenuMain_MenuWorldTrans");

port/include/stubs/menusys.hpp

@@ -4,3 +4,4 @@ extern CItemSelect     *ItemSelectPtr asm("MenuMouse_ItemSelect");
 extern ITEMCMD_RET_PARA MenuItemCmdRet asm("QuickLoadout_ItemCmdRet");
 void                    PortRetailMenuItemSelectInit(mgCMemory *stack, int *tex_block, int mode) asm("MenuSys_MenuItemSelectInit");
 void                    PortRetailMenuItemSelectDraw() asm("MenuSys_MenuItemSelectDraw");
+void                    PortRetailMenuItemDraw() asm("MenuSys_MenuItemDraw");

port/src/dng_main.cpp

@@ -1,7 +1,17 @@
 #include "common.h"
 
 #include "charasetup.hpp"
+#include "menu_world.hpp"
 #include "mg_memory.hpp"
 
+// dng_main.hpp declares BaseCharacter with retail's six elements.
+void DngMainDraw();
+void PortRetailDngMainDraw() asm("DngMain_DngMainDraw");
+
 // The seventh element is retail's BuffTempData, which SetupMainUnit reaches as stacks[6] by link adjacency on the PS2.
 PORT_OVERRIDE mgCMemory BaseCharacter[CHARA_MEM_STACK_NUM];
+
+PORT_OVERRIDE void DngMainDraw() {
+    PortRetailDngMainDraw();
+    menuworld::AfterWorldDraw();
+}

port/src/editloop.cpp

@@ -1,17 +1,26 @@
 #include "common.h"
 
 #include "bounded_text.hpp"
+#include "editloop.hpp"
 #include "mainloop.hpp"
 #include "map_port.hpp"
 #include "mapselect.hpp"
+#include "menu_world.hpp"
 #include "scene.hpp"
 
 void UpdateTrBoxFlag(int map_no);
 void PortRetailUpdateTrBoxFlag(int map_no) asm("EditLoop_UpdateTrBoxFlag");
+int  PortRetailEditDraw() asm("EditLoop_EditDraw");
 
 // Retail's update, after chests that share another chest's opened flag get their own.
 PORT_OVERRIDE void UpdateTrBoxFlag(int map_no) {
     CScene *scene = GetMainScene();
     PortSplitTreasureBoxFlags(*scene->GetMap(scene->active_map), bounded_text::View(GetMapName(map_no, nullptr)));
     PortRetailUpdateTrBoxFlag(map_no);
 }
+
+PORT_OVERRIDE int EditDraw() {
+    const int drawn = PortRetailEditDraw();
+    menuworld::AfterWorldDraw();
+    return drawn;
+}

port/src/menu_mouse_item.cpp

@@ -7,6 +7,7 @@
 #include "gamepad.hpp"
 #include "gfx/gfx.hpp"
 #include "mainloop.hpp"
+#include "menu_world.hpp"
 #include "menuaqua.hpp"
 #include "menuchr.hpp"
 #include "menucls1.hpp"
@@ -327,7 +328,8 @@ Point Start(CMenuItemInfo &menu, CMenuKeyFunc &keys) {
 
 Take TakePointer() {
     const auto &sample = MenuMouseTake();
-    pointer.pos = {.x = sample.x, .y = sample.y};
+    // Hit tests use the retail layout, so the pointer moves back the way its spread panel moved.
+    pointer.pos = {.x = menuworld::RetailPointerX(sample.x), .y = sample.y};
     pointer.pointing = sample.pointing;
     return {.pointing = sample.pointing, .moved = sample.moved || sample.clicked != 0 || sample.wheel != 0, .pressed = sample.clicked, .released = sample.released, .held = sample.held, .wheel = sample.wheel};
 }
@@ -457,12 +459,25 @@ void MenuMousePadTick() {
 
 bool MenuMouseItemActive() { return ItemPage(); }
 
+bool MenuMouseHeldItemAt(float &x, float &y) {
+    if (!ItemPage() || MenuCommonInfo->have_item.item_no <= 0) {
+        return false;
+    }
+    const MenuMouseSample sample = MenuMouseDisplaySample();
+    if (!sample.pointing) {
+        return false;
+    }
+    x = sample.x;
+    y = sample.y;
+    return true;
+}
+
 void MenuMouseItemOrigin(float &x, float &y) {
     if (!ItemPage()) {
         return;
     }
     const Point start = Start(class_menu_item_info, *MenuCommonInfo);
-    x = start.x;
+    x = menuworld::SpreadX(start.x);
     y = start.y;
 }
 

port/src/menu_mouse_item.hpp

@@ -77,3 +77,5 @@ void MenuMouseClose();
 
 bool MenuMouseItemActive();
 void MenuMouseItemOrigin(float &x, float &y);
+// Where the pointer is on screen while it carries an item on the item page.
+bool MenuMouseHeldItemAt(float &x, float &y);