updater: full migration to asyncio - #322
Open
piotrbartman wants to merge 6 commits into
Open
Conversation
- replace threads with asyncio loop to enable reliable event handling, - consolidate event-loop access to a single call in main() The loop cannot be dropped entirely: it must be the one consistent with GApplication. It's a best effort solution to make an eventual migration to newer version easier. - move blocking Admin API calls (VM start/shutdown) to an executor to prevent UI and loading spinners from freezing, - eliminate nested modal GTK loops (dialog.run()), replacing them with async dialogs, - re-enable qubesadmin caching and tied the `EventsDispatcher` listener directly to the active async loop to have real-time cache invalidation, - close window button closes the updater just after updates, - adapt tests to coroutines.
This is an artifact of gi.events (the update itself has already finished) and cannot be fixed cleanly without patching gi.events.
Member
|
For shutdown handling specifically, take a look at https://github.com/QubesOS/qubes-desktop-linux-manager/pull/312/changes |
piotrbartman
force-pushed
the
updater/async
branch
from
July 22, 2026 15:06
19c1a8a to
a4dd919
Compare
marmarek
requested changes
Jul 22, 2026
| ``asyncio.run()`` fails (it tries to set a new loop on the main thread's | ||
| context). | ||
| """ | ||
| loop = asyncio.SelectorEventLoop() |
Member
There was a problem hiding this comment.
Is this really a good idea? Isn't it better to simply take that created loop (asyncio.get_event_loop())?
Member
Author
There was a problem hiding this comment.
I focused here on maximum isolation in unit tests, but maybe it would actually be better to increase integration with the working environment
This was referenced Jul 23, 2026
Merged
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026072801-devel&flavor=pull-requests Test run included the following:
Upload failures
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update
Failed tests16 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/176874#dependencies 23 fixed
Unstable testsDetails
Performance TestsPerformance degradation:9 performance degradations
Remaining performance tests:63 tests
|
This was referenced Jul 23, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #322 +/- ##
==========================================
+ Coverage 92.67% 92.79% +0.11%
==========================================
Files 66 66
Lines 13631 13835 +204
==========================================
+ Hits 12633 12838 +205
+ Misses 998 997 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspiration was /pull/320
While searching for a solution, I went deeper and ended up with a major refactor.
First commit:
The loop cannot be dropped entirely: it must be the one consistent with GApplication.
It's a best effort solution to make an eventual migration to newer version easier.
EventsDispatcherlistener directly to the active async loop to have real-time cache invalidation,The following commits fix smaller issues loosely related to main subject.
fix QubesOS/qubes-issues/issues/10947