Fix XEmbed tray docking initialization#264
Open
besendorf wants to merge 1 commit into
Open
Conversation
Correct the embedded-notify event, decode the mapped flag using the Xlib property representation, and publish the initial embedder geometry before docking. Developed and tested with assistance from OpenAI Codex.
besendorf
force-pushed
the
agent/fix-xembed-tray-docking
branch
from
July 20, 2026 09:09
21bd6ec to
5e552d5
Compare
This was referenced Jul 20, 2026
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026072016-devel&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update
Failed tests15 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/176874#dependencies 21 fixed
Unstable testsDetails
Performance TestsPerformance degradation:28 performance degradations
Remaining performance tests:83 tests
|
This was referenced Jul 20, 2026
marmarek
reviewed
Jul 21, 2026
| conf.width = 32; | ||
| conf.height = 32; | ||
| conf.override_redirect = 0; | ||
| write_message(g->vchan, hdr, conf); |
Member
There was a problem hiding this comment.
This looks a bit risky, because the above XMoveResizeWindow() call will eventually also result in a MSG_CONFIGURE message (in response to X11 event). But, IIUC the order or messages is important here, and the other MSG_CONFIGURE will be send after MSG_DOCK. So, maybe duplicate message is less bad...
Member
|
Finally the nm-applet icon is visible: https://openqa.qubes-os.org/tests/189082#step/clipboard_and_web/3 :) |
Member
|
Is it draft because of unverified commit signature? Or something else? |
besendorf
marked this pull request as ready for review
July 22, 2026 15:07
Author
|
Converted. Can sign in about two weeks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix XEmbed tray clients that remain mapped as blank
1x1icons when proxied to a desktop tray.The live tray-docking path now:
XEMBED_EMBEDDED_NOTIFYevent instead of the address of the incoming-event pointer;XEMBED_MAPPEDusing theunsigned longrepresentation returned byXGetWindowProperty();32x32default embedder geometry; andMSG_DOCK, matching the ordering used when full window state is resent.Root cause
The incorrect
XSendEvent()argument prevented clients from receivingXEMBED_EMBEDDED_NOTIFY.Fixing only that call was insufficient for clients initially created at
1x1: dom0 still knew the pre-dock window as1x1and configured the docked client back to that size. Additionally, reading a format-32 X property throughint *selects the wrong slot on 64-bit systems, so the mapped flag could be missed.Validation
gui-agent/qubes-guifrom a clean object state with the project's-Wall -Wextra -Werrorflags.xembedsniproxyin dom0.1x1changed from receiving no embedded notification and remaining1x1to receivingXEMBED_EMBEDDED_NOTIFY,MapNotify, and a stable32x32configure event.32x32andIsViewable.sys-netwith the realnm-applet; the previously blank NetworkManager icon became visible and was tinted with the qube's red label color.AI assistance disclosure
This change was developed and tested with assistance from OpenAI Codex. The runtime tests and final visual confirmation were performed interactively on the affected Qubes OS system.