Call stop_encrypted() even for nominally unencrypted volumes#851
Merged
marmarek merged 2 commits intoJul 23, 2026
Merged
Conversation
rustybird
force-pushed
the
unconditionally_call_stop_encrypted
branch
from
July 22, 2026 15:26
fd79d5a to
4a9d4ab
Compare
marmarek
requested changes
Jul 22, 2026
rustybird
force-pushed
the
unconditionally_call_stop_encrypted
branch
from
July 22, 2026 16:13
4a9d4ab to
cb723bb
Compare
A volume's ephemeral property might have become False while the volume was already started, e.g. by changing the pool level default with 'qvm-pool set -o ephemeral_volatile=False'
admin.pool.Set.ephemeral_volatile already had no such restriction.
rustybird
force-pushed
the
unconditionally_call_stop_encrypted
branch
from
July 22, 2026 16:17
cb723bb to
9b92297
Compare
Contributor
Author
|
Force-pushed again to remove a stray dot from the docstring diff |
This was referenced Jul 23, 2026
Open
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026072219-devel&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update
Failed tests14 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/176874#dependencies 27 fixed
Unstable testsDetails
Performance TestsPerformance degradation:42 performance degradations
Remaining performance tests:69 tests
|
marmarek
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit messages