Allow all storage drivers to shrink volumes, like file-reflink#835
Allow all storage drivers to shrink volumes, like file-reflink#835rustybird wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #835 +/- ##
==========================================
- Coverage 70.46% 70.33% -0.14%
==========================================
Files 61 61
Lines 14161 14137 -24
==========================================
- Hits 9979 9943 -36
- Misses 4182 4194 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
993afd2 to
5ca3b70
Compare
|
@Rudd-O: Are you sure that OpenZFS's Maybe it fails if snapshots of the zvol exist? If OpenZFS does support shrinking even then, I propose to add this commit to the PR: rustybird@shrink-volumes-zfs |
|
After setting up ZFS, I tested shrinking a 'zfs' driver volume and it worked fine. So I've added that commit to the PR. |
8a961f8 to
cee4105
Compare
Similar in purpose to #477, #478, #479 by @a-barinov in 2022, but with the shrinking check happening on the frontend side as suggested by @marmarek. The frontend already had such a check but only in the
qvm-volumetool; QubesOS/qubes-core-admin-client#475 centralizes this check toqubesadmin.storage.Volume.resize()so that any other callers are protected as well. (Qube Manager's qube Settings dialog /qubes-vm-settingsalso has its own logic that avoids callingresize()if it would shrink.)