Memoize API methods - #849
Merged
Merged
Conversation
Prior to this change, executing qubes-prefs requests two API methods, and took this much time to "list_methods" (format: CALL -> SECS): 0 -> 0.000520 0 -> 0.000404 1 -> 0.000237 1 -> 0.000183 2 -> 0.000468 2 -> 0.000199 3 -> 0.000277 3 -> 0.000207 With this change: 0 -> 0.000194 0 -> 0.000133 1 -> 0.000007 1 -> 0.000006 2 -> 0.000004 2 -> 0.000003 3 -> 0.000007 3 -> 0.000004 Suggested-by: Demi Marie Obenour <demiobenour@gmail.com> For: QubesOS/qubes-issues#10775
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #849 +/- ##
==========================================
- Coverage 70.37% 70.32% -0.06%
==========================================
Files 61 61
Lines 14179 14164 -15
==========================================
- Hits 9979 9961 -18
- Misses 4200 4203 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
marmarek
reviewed
Jul 21, 2026
By decoupling the listing method from the candidate selection, we lower time to get candidate from uncached method from 0.000300 to 0.000050.
ben-grande
force-pushed
the
cache-methods
branch
from
July 21, 2026 22:28
ec4ab50 to
189df41
Compare
Contributor
Author
|
If The |
Drop time to list uncached method from 0.000050 to 0.000010.
0 -> 0.000007
ProtocolError("no such method: 'a'")
1 -> 0.000017
ProtocolError("no such method: 'b'")
2 -> 0.000007
ProtocolError("no such method: 'c'")
3 -> 0.000014
ProtocolError("no such method: 'd'")
ben-grande
force-pushed
the
cache-methods
branch
from
July 22, 2026 06:18
e15a71e to
82bcfaf
Compare
Contributor
Author
|
Qubesd startup makes 200 calls, the loading of methods took |
This was referenced Jul 31, 2026
Merged
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026080104-devel&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update
Failed tests12 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/176874#dependencies 26 fixed
Unstable testsDetails
Performance TestsPerformance degradation:28 performance degradations
Remaining performance tests:83 tests
|
This was referenced Jul 31, 2026
marmarek
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change, executing qubes-prefs requests two API methods, and took this much time to "list_methods" (format: CALL -> SECS):
0 -> 0.000520
0 -> 0.000404
1 -> 0.000237
1 -> 0.000183
2 -> 0.000468
2 -> 0.000199
3 -> 0.000277
3 -> 0.000207
With this change:
0 -> 0.000194
0 -> 0.000133
1 -> 0.000007
1 -> 0.000006
2 -> 0.000004
2 -> 0.000003
3 -> 0.000007
3 -> 0.000004
Suggested-by: Demi Marie Obenour demiobenour@gmail.com
For: QubesOS/qubes-issues#10775