Do not crash qvm-start-daemon on VMs without xid property - #483
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #483 +/- ##
==========================================
+ Coverage 76.71% 76.85% +0.13%
==========================================
Files 53 53
Lines 9428 9432 +4
==========================================
+ Hits 7233 7249 +16
+ Misses 2195 2183 -12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This especially applies to RemoteVM, but may appy to other classes in the future too. Similarly, this also avoids the crash in interface qube that doesn't have full access to some other qubes. Fixes QubesOS/qubes-issues#10985
marmarek
force-pushed
the
start-daemon-remotevm
branch
from
July 25, 2026 02:09
71e2e1c to
ad6a550
Compare
This was referenced Jul 31, 2026
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026073102-devel&flavor=pull-requests Test run included the following:
Upload failures
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update
Failed tests16 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/176874#dependencies 21 fixed
Unstable testsDetails
Performance TestsPerformance degradation:22 performance degradations
Remaining performance tests:89 tests
|
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This especially applies to RemoteVM, but may appy to other classes in
the future too. Similarly, this also avoids the crash in interface qube
that doesn't have full access to some other qubes.
Fixes QubesOS/qubes-issues#10985