Handle more events and deprecate Transient state#480
Draft
ben-grande wants to merge 4 commits into
Draft
Conversation
When checking libvirt event callbacks, VIR_DOMAIN_EVENT_STOPPED is the only event called when shutting down or destroying/killing a domain, so the state transitions from Running->Halted, therefore, never sending "Halting" or "Dying". I checked the clients, and only qubes-manager uses "Dying", but it has a "Halting" equivalent, which all translate to the same visuals as "Transient".
Variables set on the module level so it can be reused by other clients.
ben-grande
added a commit
to ben-grande/qubes-desktop-linux-manager
that referenced
this pull request
Jul 15, 2026
Cache events to allow caching power state and avoid extra API calls. With that, also trust the client to return us the appropriate power state that it set on the event, instead of making derivative tools roll their own state definition. Fixes: QubesOS/qubes-issues#10977 Fixes: QubesOS/qubes-issues#10978 For: QubesOS/qubes-issues#10966 Requires: QubesOS/qubes-core-admin-client#480
ben-grande
added a commit
to ben-grande/qubes-desktop-linux-manager
that referenced
this pull request
Jul 15, 2026
ben-grande
added a commit
to ben-grande/qubes-desktop-linux-menu
that referenced
this pull request
Jul 15, 2026
Cache events to allow caching power state and avoid extra API calls. With that, also trust the client to return us the appropriate power state that it set on the event, instead of making derivative tools roll their own state definition. Fixes: QubesOS/qubes-issues#10979 For: QubesOS/qubes-issues#10966 Requires: QubesOS/qubes-core-admin-client#480
ben-grande
added a commit
to ben-grande/qubes-desktop-linux-menu
that referenced
this pull request
Jul 15, 2026
ben-grande
added a commit
to ben-grande/qubes-desktop-linux-manager
that referenced
this pull request
Jul 15, 2026
Cache events to allow caching power state and avoid extra API calls. With that, also trust the client to return us the appropriate power state that it set on the event, instead of making derivative tools roll their own state definition. Fixes: QubesOS/qubes-issues#10977 Fixes: QubesOS/qubes-issues#10978 For: QubesOS/qubes-issues#10966 Requires: QubesOS/qubes-core-admin-client#480
ben-grande
added a commit
to ben-grande/qubes-desktop-linux-manager
that referenced
this pull request
Jul 15, 2026
Besides the name "Transient" means impermanent, it could as well take a long time in case the qrexec agent on the qube broke. Also it doesn't help anything knowing that via the power state, it should be broadcasted in another manner. It also doesn't tell the clients why it is in a transient state, while "Starting" and "Halting" really does tell us what is happening. For: QubesOS/qubes-issues#10964 For: QubesOS/qubes-issues#10966
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #480 +/- ##
==========================================
+ Coverage 76.79% 76.80% +0.01%
==========================================
Files 53 53
Lines 9402 9412 +10
==========================================
+ Hits 7220 7229 +9
- Misses 2182 2183 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft as it was not tested at all.
Fixes: QubesOS/qubes-issues#10964
For: QubesOS/qubes-issues#10966