Add top-like monitoring tool#333
Conversation
Do you mean read() hangs for you? Maybe the service waits for something before starting to output any data (doesn't look like it based on the other PR...). |
|
Not the service by default, I prepended sleep to awk to test if a DomU
could hang operation on Dom0 and if this is a valid concern.
…On Tue, Jan 28, 2025, 12:25 PM Marek Marczykowski-Górecki < ***@***.***> wrote:
is a blocking operation as well as proc.stdout.read(2)
Do you mean read() hangs for you? Maybe the service waits for something
before starting to output any data (doesn't look like it based on the other
PR...).
—
Reply to this email directly, view it on GitHub
<#333 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BCE2O4LDOXXM2LA43ENCLQ32M5SKPAVCNFSM6AAAAABWAFNTCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJYG4ZDGNBUG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Based on discussion in the other PR, this should be converted to use stat events (and events extended to include necessary info). Converting to draft until then. |
75a9ee5 to
bc049c9
Compare
|
LLM helped on |
2af82dc to
a5b743e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #333 +/- ##
==========================================
- Coverage 76.79% 68.30% -8.49%
==========================================
Files 53 54 +1
Lines 9402 10586 +1184
==========================================
+ Hits 7220 7231 +11
- Misses 2182 3355 +1173 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
One thing I don't plan to fix is the memory reporting being wrong, as only qmemman has the knowledge about memory of each qube, and getting information from it is not currently nice with it's current API (synchonous), and I don't want to delay reporting statistics because qmemman is busy for seconds at a time. |
|
Maybe it's not necessary, reading past conversations, something that I didn't understand one year ago (qmemman, admin.vm.Stats), I think I will settle for meminfo: QubesOS/qubes-core-agent-linux#550 (comment). |
|
|
And one more bug, for dom0, it should use |
|
And yes, |
4ab3c3a to
8027157
Compare
|
I'm not sure either, but I guess Anyway, I don't like exposing stubdomains in a high level tool, it should be counted as part of the target qube; if anything, maybe some separate column for some internal overhead, but not separate row. |
When checking libvirt event callbacks, VIR_DOMAIN_EVENT_STOPPED is the only event called when shutting down or destroying/killing a domain, so the state transitions from Running->Halted, therefore, never sending "Halting" or "Dying". I checked the clients, and only qubes-manager uses "Dying", but it has a "Halting" equivalent, which all translate to the same visuals as "Transient".
Variables set on the module level so it can be reused by other clients.
|
PR rebased on top of: |
Besides the name "Transient" means impermanent, it could as well take a long time in case the qrexec agent on the qube broke. Also it doesn't help anything knowing that via the power state, it should be broadcasted in another manner. It also doesn't tell the clients why it is in a transient state, while "Starting" and "Halting" really does tell us what is happening. For: QubesOS/qubes-issues#10964 For: QubesOS/qubes-issues#10966
Cut in half the to get derived qubes.
Inspiration and code from qui-domains and visuals from xentop. - Color data, when possible, qube names are colored according to label, it works okay on XTerm (except orang) but colors render perfectly on Xfce4-terminal. The black label is just printed as the default foreground color, because using standout on it would be unnecessary highlight. - Clock to show last time the screen was refreshed - Allows scrolling domain list when it is longer than the screen height, with a less-style type hint indicating pages - To scroll, readline style (Emacs) navigation is supported, with some Vi keys also supported. Mouse navigation is also supported. - Inexpensive calls using "admin.vm.Stats" - Can show only columns you specify - Shows all non-halted domains by default, but can show only specified ones also - Screen refresh is delayed until needed, small sleep to avoid user perceiving delays when scrolling - Can sort per column and click again to reverse the sort, with a little indicator at the end of the column - Can filter list of domains after the program is already running - Can act based on common actions available from all selected domains, such as kill if qubes are running, start if qubes are halted
Strings are trusted, they are just label and name. But some values such as those reported by the qube via xenstore keys, are not so trusted and can be large integers. Instead of printing dubious data, print an ellipsis to symbolize it wouldn't fit. It might be a programming error, might be a malicious information, fall on the safe side.
- Swap column introduced to know when the qube should have more memory, swaping is never nice. - Columns are ordered in "total", "standard", "internal". - Do not consider percentage intensity when irrelevant
The "min_width" is used to avoid the columns moving too much.
This is not perfect, if the list change and the qube is not in the visible section anymore, it will go back to the first row.
It is still shown when "show_halted" is enabled, just to view the qubes in the system, but obviously, it can't display any statistic or run any action on it.
96844be to
7e6632a
Compare
2 participants
Add top-like monitoring tool
Inspiration and code from qui-domains and visuals from xentop.
with a less-type hint indicating how many lines to scroll
Vi keys also supported
Requires: QubesOS/qubes-core-admin#827
This PR is based on top of:
Transientstate #480