Skip to content

Replace Transient state for Starting and Halting#455

Draft
ben-grande wants to merge 3 commits into
QubesOS:mainfrom
ben-grande:transient
Draft

Replace Transient state for Starting and Halting#455
ben-grande wants to merge 3 commits into
QubesOS:mainfrom
ben-grande:transient

Conversation

@ben-grande

@ben-grande ben-grande commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@ben-grande ben-grande linked an issue Jul 15, 2026 that may be closed by this pull request
@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.66%. Comparing base (b2fea1d) to head (133b4c6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #455      +/-   ##
==========================================
- Coverage   69.71%   69.66%   -0.05%     
==========================================
  Files          17       17              
  Lines        4029     4029              
==========================================
- Hits         2809     2807       -2     
- Misses       1220     1222       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ben-grande

Copy link
Copy Markdown
Contributor Author

Without this PR, the application crashes when it sees a power state it is not aware of, such as Starting. This PR fixes it, but for next time, each client application should handle unknown states gracefully.

Jul 16 17:06:21 dom0 python3[186072]: Traceback (most recent call last):
                                        File "/usr/lib/python3.13/site-packages/qubesmanager/qube_manager.py", line 173, in paint
                                          self.stateIcons[index.data()['power']].pixmap(iconSize))
                                          ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
                                      KeyError: 'Starting'
Jul 16 17:06:21 dom0 systemd-coredump[187813]: [] Process 186072 (qubes-qube-mana) of user 1000 dumped core.

Is a transition period necessary? Where the server sends Transient in place of Starting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve handling of Transient power state

1 participant