-
Notifications
You must be signed in to change notification settings - Fork 121
Add observed ion mobility and CCS to chromatogram extraction #4301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bspratt
wants to merge
57
commits into
master
Choose a base branch
from
Skyline/work/20260504_im_error
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 24 commits
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
d83da9e
Added intensity-weighted IM-error accumulation in chrom extraction
bspratt 9dab2d0
Added IM/CCS error array support to ChromCollector and TimeIntensities
bspratt 1740ebb
Wired IM error through chrom collector and time series transforms
bspratt 9e55871
Bumped cache format to v20 with per-time-point IM error storage
bspratt 470ff66
Added per-peak IM and CCS error fields to ChromPeak and TransitionChr…
bspratt 288a9ff
Surfaced IM/CCS error percent in Document Grid
bspratt d208222
Pivoted IM error model to absolute observed IM/CCS with COG-bin-index…
bspratt 08dfc40
Merge remote-tracking branch 'origin/master' into Skyline/work/202605…
bspratt a7146d5
Added FAIMS gate and v19->v20 cache compat unit tests
bspratt 177bc05
Added isotope-envelope idotp guard for observed-IM extraction
bspratt 294ee43
just adding a @ to a non-localized string for quiet inspection
bspratt c5ea4ed
Encoded per-time-point observed ion mobility as scaled integers in cache
bspratt 29975f8
Added tiered windowed idotp guard for observed ion mobility
bspratt 03a270a
Removed the IM strategy-comparison diagnostic dump
bspratt a080538
Visualized observed ion mobility in the Full Scan graph
bspratt 5e1d5d3
Fixed PauseAndContinueForm truncating multi-paragraph messages
bspratt dadd981
Cleaned up incidental ReSharper inspections
bspratt b1764e4
Regenerated report column reference docs for the new IM columns
bspratt 7e7ae66
Merge remote-tracking branch 'origin/master' into Skyline/work/202605…
bspratt 3754a39
Read observed ion mobility at the peak apex-of-valid
bspratt 07f4ea1
Aligned Full Scan CCS-error target with the Document Grid
bspratt 35447af
Merge remote-tracking branch 'origin/master' into Skyline/work/202605…
bspratt c1acdb2
Excluded FAIMS and SONAR from observed ion mobility tracking
bspratt 82e833c
Merge remote-tracking branch 'origin/master' into Skyline/work/202605…
bspratt e0395aa
Merge branch 'master' into Skyline/work/20260504_im_error
bspratt 845f207
Addressed Copilot review feedback on PR #4301
bspratt 1b5b732
Addressed Copilot review round 2 on PR #4301
bspratt fcd321e
Refactored CollectSurvivingBins to clear ReSharper null-deref warnings
bspratt 0f71bd5
Honored per-transition Missing flags when reading the interpolated st…
bspratt 20b2a96
clean up a couple of code inspection errors
bspratt f3bb33e
Merge branch 'master' into Skyline/work/20260504_im_error
bspratt 225b265
clean up a code inspection error
bspratt be50e7c
Addressed Copilot review feedback on PR #4301
bspratt fbc1b26
Added a Full Scan observed-IM tooltip screenshot seam for the Small M…
bspratt 21f719d
Show observed ion mobility / CCS percent error to 2 decimals
bspratt 516d8b1
Merge observed-IM tooltip into the IM-filtering tutorial shot; reword…
bspratt 001dae7
Refine Full Scan observed-IM tooltip labels and mobilogram width
bspratt cf22eee
Merge branch 'master' into Skyline/work/20260504_im_error
bspratt f1c0c64
Merge branch 'master' into Skyline/work/20260504_im_error
bspratt 48db259
Merge branch 'master' into Skyline/work/20260504_im_error
bspratt be430dc
Added mobility-peak metrics (area/height/FWHM) to the Full Scan obser…
bspratt 83c4238
Merge remote-tracking branch 'origin/master' into Skyline/work/202605…
bspratt 9135e89
Merge remote-tracking branch 'origin/Skyline/work/20260504_im_error' …
bspratt 4eb7335
Merge branch 'master' into Skyline/work/20260504_im_error
nickshulman cc44c55
Merge branch 'master' into Skyline/work/20260504_im_error
bspratt f885a5c
Merge branch 'master' into Skyline/work/20260504_im_error
bspratt 30ca73b
Reworked observed ion mobility to a single per-ion value
bspratt 3c1f836
Added MS2-only fallback and a test for the per-ion observed IM
bspratt c9ec7c9
Regenerated report-column help for the per-precursor observed IM/CCS …
bspratt f155e71
Made the per-ion observed IM aggregation unit-testable and covered th…
bspratt cdfd166
Fixed observed-IM review findings: null-IM bias, small-molecule + fal…
bspratt 174d127
Cached the per-ion observed IM/CCS aggregate, computed in one pass
bspratt c360832
Moved observed-IM aggregation from the report entity into the model
bspratt 17a1b31
Merge remote-tracking branch 'origin/master' into Skyline/work/202605…
bspratt 1567cc3
Removed a redundant cast/ternary flagged by ReSharper inspection
bspratt b2a2c79
Merge branch 'master' into Skyline/work/20260504_im_error
bspratt 08251bb
Merge branch 'master' into Skyline/work/20260504_im_error
bspratt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
52 changes: 49 additions & 3 deletions
52
pwiz_tools/Skyline/Controls/Graphs/GraphsResources.designer.cs
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.