Fix display of mod with extra long display name - #6436
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request improves text wrapping and truncation behavior in the UI. In TwoLineListItem, lblTitle is configured to grow with a minimum width of 0. In ModListPageSkin, text wrapping is enabled for the mod info dialog title, and text overrun is set to ellipsis for the mod info list cell. The review feedback suggests two layout refinements: setting HBox.setHgrow(tagsBox, Priority.NEVER) in TwoLineListItem to prevent premature truncation of the title, and setting HBox.setHgrow(title, Priority.ALWAYS) in ModInfoDialog to ensure the title properly wraps within the available width.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
这个问题在 #5435 顺带修了 但是那个PR不知道什么时候才能合并 所以挺好 |
This reverts commit ca68af0.
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bcca2441e5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| modInfo.loadIcon(imageContainer, null); | ||
|
|
||
| TwoLineListItem title = new TwoLineListItem(); | ||
| title.getTitleLabel().setWrapText(true); |
There was a problem hiding this comment.
For a mod whose metadata or translation contains a sufficiently long display name, unrestricted wrapping makes the heading's preferred height grow without bound. These names are not length-limited when parsed, while this dialog caps only the description viewport and provides neither a maximum height nor scrolling for the heading, so the dialog can grow taller than the launcher and push its body and action buttons outside the visible area; constrain the heading height or place the overall dialog content in a bounded scrolling container.
Useful? React with 👍 / 👎.
3 participants
共两个commits。第一个commit修复了在模组列表里名称（+译名）非常长的模组会将右侧的两个按钮挤走的问题：
既然列表里名字不一定是全名，那就另外需要一处可以展示全名的界面。第二个commit修复了详细信息页面里超长模组名的显示问题：