Skip to content

Fix display of mod with extra long display name #6436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ZZZank wants to merge 5 commits into
base: main
Choose a base branch
from
+4 −1
Open

Fix display of mod with extra long display name #6436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
37c2088
avoid mod with super long display name from pushing buttons outside
ZZZank Jul 19, 2026
a069ce6
fix display of mod with super long display name in mod dialog
ZZZank Jul 19, 2026
ca68af0
make tags always visible
ZZZank Jul 19, 2026
0157781
Revert "make tags always visible"
ZZZank Jul 20, 2026
bcca244
Merge remote-tracking branch 'upstream/main' into mod-display-length
Glavo Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion HMCL/src/main/java/org/jackhuang/hmcl/ui/construct/TwoLineListItem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,8 @@ public ObservableList<Label> getTags() {

FXUtils.setOverflowHidden(tagsBox);

lblTitle.setMinWidth(Label.USE_PREF_SIZE);
HBox.setHgrow(lblTitle, Priority.ALWAYS);
lblTitle.setMinWidth(0);
firstLine.getChildren().setAll(lblTitle, tagsBox);
Comment thread
ZZZank marked this conversation as resolved.
}
return tags;
Expand Down
2 changes: 2 additions & 0 deletions HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/ModListPageSkin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,7 @@ final class ModInfoDialog extends JFXDialogLayout {
modInfo.loadIcon(imageContainer, null);

TwoLineListItem title = new TwoLineListItem();
title.getTitleLabel().setWrapText(true);

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Cap the wrapped dialog title height

For a mod whose metadata or translation contains a sufficiently long display name, unrestricted wrapping makes the heading's preferred height grow without bound. These names are not length-limited when parsed, while this dialog caps only the description viewport and provides neither a maximum height nor scrolling for the heading, so the dialog can grow taller than the launcher and push its body and action buttons outside the visible area; constrain the heading height or place the overall dialog content in a bounded scrolling container.

Useful? React with 👍 / 👎.

if (modInfo.getModTranslations() != null && I18n.isUseChinese())
Comment thread
ZZZank marked this conversation as resolved.
title.setTitle(modInfo.getModTranslations().getDisplayName());
else
Expand Down Expand Up @@ -565,6 +566,7 @@ final class ModInfoListCell extends MDListCell<ModInfoObject> {
container.setAlignment(Pos.CENTER_LEFT);
HBox.setHgrow(content, Priority.ALWAYS);
content.setMouseTransparent(true);
content.getTitleLabel().setTextOverrun(OverrunStyle.ELLIPSIS);
setSelectable();

imageContainer.setImage(GameInstanceIconType.COMMAND.getIcon());
Expand Down