Skip to content

Fix display of mod with extra long display name #6436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ZZZank wants to merge 5 commits into
base: main
Choose a base branch
from
+4 −1
Open

Fix display of mod with extra long display name #6436

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
37c2088
avoid mod with super long display name from pushing buttons outside
ZZZank Jul 19, 2026
a069ce6
fix display of mod with super long display name in mod dialog
ZZZank Jul 19, 2026
ca68af0
make tags always visible
ZZZank Jul 19, 2026
0157781
Revert "make tags always visible"
ZZZank Jul 20, 2026
bcca244
Merge remote-tracking branch 'upstream/main' into mod-display-length
Glavo Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions HMCL/src/main/java/org/jackhuang/hmcl/ui/construct/TwoLineListItem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import javafx.scene.control.Label;
import javafx.scene.layout.HBox;
import javafx.scene.layout.Priority;
import javafx.scene.layout.Region;
import javafx.scene.layout.VBox;
import org.jackhuang.hmcl.ui.FXUtils;

Expand Down Expand Up @@ -167,16 +168,17 @@ public ObservableList<Label> getTags() {
var tagsBox = new HBox(8);
tagsBox.getStyleClass().add("tags");
tagsBox.setAlignment(Pos.CENTER_LEFT);
tagsBox.setMinWidth(0);
HBox.setHgrow(tagsBox, Priority.ALWAYS);
tagsBox.setMinWidth(Region.USE_PREF_SIZE);
Comment thread
ZZZank marked this conversation as resolved.
Outdated
HBox.setHgrow(tagsBox, Priority.NEVER);
Bindings.bindContent(tagsBox.getChildren(), tags);
var isNotEmpty = Bindings.isNotEmpty(tags);
tagsBox.managedProperty().bind(isNotEmpty);
tagsBox.visibleProperty().bind(isNotEmpty);

FXUtils.setOverflowHidden(tagsBox);

lblTitle.setMinWidth(Label.USE_PREF_SIZE);
HBox.setHgrow(lblTitle, Priority.ALWAYS);
lblTitle.setMinWidth(0);
firstLine.getChildren().setAll(lblTitle, tagsBox);
Comment thread
ZZZank marked this conversation as resolved.
}
return tags;
Expand Down
2 changes: 2 additions & 0 deletions HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModListPageSkin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,7 @@ final class ModInfoDialog extends JFXDialogLayout {
modInfo.loadIcon(imageContainer, null);

TwoLineListItem title = new TwoLineListItem();
title.getTitleLabel().setWrapText(true);
if (modInfo.getModTranslations() != null && I18n.isUseChinese())
title.setTitle(modInfo.getModTranslations().getDisplayName());
else
Expand Down Expand Up @@ -544,6 +545,7 @@ final class ModInfoListCell extends MDListCell<ModInfoObject> {
container.setAlignment(Pos.CENTER_LEFT);
HBox.setHgrow(content, Priority.ALWAYS);
content.setMouseTransparent(true);
content.getTitleLabel().setTextOverrun(OverrunStyle.ELLIPSIS);
setSelectable();

imageContainer.setImage(VersionIconType.COMMAND.getIcon());
Expand Down
Loading