Skip to content

replace always stay on top with proper parenting to Unreals main window - #269

Merged
antirotor merged 4 commits into
ynput:developfrom
dev-holobay:qt-parenting
Jun 8, 2026
Merged

replace always stay on top with proper parenting to Unreals main window#269
antirotor merged 4 commits into
ynput:developfrom
dev-holobay:qt-parenting

Conversation

@nebukadhezer

Copy link
Copy Markdown
Contributor

Changelog Description

Instead of using Qts StayOnTop logic, we use unreals parenting of window ids, so when unreal is minimized all windows are minimized too and restored on maximise.

Added the console, think it is nice in unreal to have it.

Though the implementation deviates from all the other apps.

So lets discuss if this is sth that should be changed in core too, so the console can be implemented the same way.

@nebukadhezer

Copy link
Copy Markdown
Contributor Author

this would close #270

@antirotor antirotor added community Issues and PRs coming from the community members type: enhancement Improvement of existing functionality or minor addition labels May 25, 2026
@antirotor

antirotor commented May 25, 2026

Copy link
Copy Markdown
Member

Thanks, I think this PR is nice to merge. Needs some more support from ayon-core as other tools are not behaving the same and if you open publisher for example (or other tools really) it will break the parenting of the console until you close the tools again.

I would still merge it as it is definitely enhancing current state but I'll create another issue in ayon-core and here to add this to other tools.

Mark it as Ready for review whenever ready.

@antirotor

Copy link
Copy Markdown
Member

With this merged ynput/ayon-core#1856 and this
change here:

    def _on_tool_require(self, tool_name):
        tool = host_tools.show_tool_by_name(tool_name, parent=self)
        if tool:
            unreal.parent_external_window_to_slate(tool.winId())

(I would fix it, but I don't have permissions to push to this fork)

@nebukadhezer

Copy link
Copy Markdown
Contributor Author

uh I completely forgot about the pr... I still had issues, thats why I had not opened it, and I had not had the time to chase them down, but it was behaving weirdly, I also looked a bit into a proper menu in unreal... but I had used a third party dependecy "unimenu" for this in the past.

I think tomorrow I can implement the change and change the PR from draft to ready.

@nebukadhezer
nebukadhezer marked this pull request as ready for review May 26, 2026 14:44
@nebukadhezer

Copy link
Copy Markdown
Contributor Author

@antirotor implemented your change and updated the branch

@antirotor antirotor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it and it works, thannks to the condition it is also bacwards comaptible with older core versions. Thanks for the contribution!

@antirotor

Copy link
Copy Markdown
Member

We just need to merge in latest changes in develop.

@antirotor
antirotor merged commit c2d7fd8 into ynput:develop Jun 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Issues and PRs coming from the community members type: enhancement Improvement of existing functionality or minor addition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants