replace always stay on top with proper parenting to Unreals main window - #269
Conversation
|
this would close #270 |
|
Thanks, I think this PR is nice to merge. Needs some more support from ayon-core as other tools are not behaving the same and if you open publisher for example (or other tools really) it will break the parenting of the console until you close the tools again. I would still merge it as it is definitely enhancing current state but I'll create another issue in ayon-core and here to add this to other tools. Mark it as Ready for review whenever ready. |
|
With this merged ynput/ayon-core#1856 and this def _on_tool_require(self, tool_name):
tool = host_tools.show_tool_by_name(tool_name, parent=self)
if tool:
unreal.parent_external_window_to_slate(tool.winId())(I would fix it, but I don't have permissions to push to this fork) |
|
uh I completely forgot about the pr... I still had issues, thats why I had not opened it, and I had not had the time to chase them down, but it was behaving weirdly, I also looked a bit into a proper menu in unreal... but I had used a third party dependecy "unimenu" for this in the past. I think tomorrow I can implement the change and change the PR from draft to ready. |
|
@antirotor implemented your change and updated the branch |
antirotor
left a comment
There was a problem hiding this comment.
I've tested it and it works, thannks to the condition it is also bacwards comaptible with older core versions. Thanks for the contribution!
|
We just need to merge in latest changes in develop. |
Changelog Description
Instead of using Qts StayOnTop logic, we use unreals parenting of window ids, so when unreal is minimized all windows are minimized too and restored on maximise.
Added the console, think it is nice in unreal to have it.
Though the implementation deviates from all the other apps.
So lets discuss if this is sth that should be changed in core too, so the console can be implemented the same way.