Tools: show functions returning QWidget - #1856
Merged
Merged
Conversation
make all `show_*()` function to return QWidget so the code calling it can work with it. Also add some type annotations and docstrings.
iLLiCiTiT
approved these changes
May 25, 2026
iLLiCiTiT
reviewed
May 25, 2026
iLLiCiTiT
reviewed
May 25, 2026
iLLiCiTiT
reviewed
May 25, 2026
iLLiCiTiT
reviewed
May 25, 2026
iLLiCiTiT
reviewed
May 25, 2026
iLLiCiTiT
reviewed
May 25, 2026
iLLiCiTiT
reviewed
May 25, 2026
iLLiCiTiT
reviewed
May 25, 2026
iLLiCiTiT
reviewed
May 25, 2026
iLLiCiTiT
reviewed
May 25, 2026
iLLiCiTiT
reviewed
May 25, 2026
iLLiCiTiT
reviewed
May 25, 2026
iLLiCiTiT
reviewed
May 25, 2026
iLLiCiTiT
reviewed
May 25, 2026
iLLiCiTiT
reviewed
May 25, 2026
iLLiCiTiT
reviewed
May 25, 2026
iLLiCiTiT
reviewed
May 25, 2026
iLLiCiTiT
reviewed
May 25, 2026
iLLiCiTiT
reviewed
May 25, 2026
iLLiCiTiT
reviewed
May 25, 2026
iLLiCiTiT
reviewed
May 25, 2026
iLLiCiTiT
reviewed
May 25, 2026
iLLiCiTiT
reviewed
May 25, 2026
iLLiCiTiT
reviewed
May 25, 2026
iLLiCiTiT
reviewed
May 25, 2026
iLLiCiTiT
reviewed
May 25, 2026
iLLiCiTiT
reviewed
May 25, 2026
BigRoy
reviewed
May 25, 2026
BigRoy
left a comment
Member
There was a problem hiding this comment.
Nice. I agree with essentially all of @iLLiCiTiT 's suggestions here - so after that looks good to me.
apply suggestions, remove unnecessary import
Member
Author
but then you would basically need to reimplement all applied suggestions. |
iLLiCiTiT
reviewed
Jun 1, 2026
iLLiCiTiT
reviewed
Jun 1, 2026
iLLiCiTiT
reviewed
Jun 1, 2026
iLLiCiTiT
reviewed
Jun 1, 2026
iLLiCiTiT
reviewed
Jun 1, 2026
sorry for this but I need to read it
iLLiCiTiT
approved these changes
Jun 1, 2026
Member
Yeah, you kinda had to reimplement everything here instead... |
This was referenced Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Make all
show_*()functions to return QWidget so the code calling it can work with it. Also add some type annotations and docstrings.Additional info
This is needed for example in Unreal, where you need to call
unreal.parent_external_window_to_slate()onwinId()of the widget. Might be useful for other things too.Tip
For PR that can make use of it, see ynput/ayon-unreal#269
Testing notes:
Without proper support this cannot be easily tested. However, all should work as before.