Repository navigation
Add entrant slot descriptors to knockout stages - #49
Merged
Merged
Conversation
Phase 2 of World Cup style advancement. A knockout stage can now declare where each round-1 slot's team comes from instead of pulling raw season teams, via config.entrants — an ordered descriptor list where consecutive pairs are the round-1 matchups: ['type' => 'group', 'group' => 'Group A', 'position' => 1] Winner Group A ['type' => 'best_placed', 'rank' => 2] 2nd-best placed - EntrantSlot value object validates/normalizes descriptors and renders labels (Winner Group A / Runner-up Group B / Best-placed #4) - SingleEliminationGenerator gains an entrant mode: all-TBD bracket sized to the list (power of two enforced), filled later by the seeding action - Bracket view shows descriptor labels on unfilled round-1 slots - Stage edit page gains an entrant builder for bracket stages: classic cross-pair and seeded templates computed from the previous grouped stage, plus per-slot select editing Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase ② of World Cup–style advancement (follows #48). A knockout stage can now declare where each round-1 slot's team comes from via
config.entrants— an ordered descriptor list where consecutive pairs are the round-1 matchups, so the list is the pairing template (1A v 2B, 1C v 3rd-placed, …).EntrantSlotvalue object: validates/normalizes the two descriptor shapes (group+position,best_placed+rank) and renders labels — Winner Group A, Runner-up Group B, 3rd Group C, Best-placed Phase 3a: Stage + Group domain (schema, models, policies) #4.SingleEliminationGeneratorentrant mode: with entrants configured, fixtures generate as an all-TBD bracket sized to the list (power-of-two enforced) instead of seeding from season teams.AdvanceBracketWinnerneeds zero changes — same round/bracket_position coordinates.sourceStageprop) — Classic template (1A v 2B …, group-mates in opposite halves), Seeded template (winners → runners-up → best-placed with standard bracket seeding, works for any power-of-two shape incl. 12 groups + 8 thirds = 32), and per-slot select editing.Phase ③ (next PR):
SeedStageFromGroups— resolving these descriptors against the group-stage standings with an admin confirm step, plus draw-mode pairing.Testing
🤖 Generated with Claude Code