Repository navigation
Mark unplayed games Full Time when a result is entered manually - #51
Merged
Merged
Conversation
Recording a result through the manual editor left the game's status untouched, so played games sat at scheduled forever. Standings still looked right (they read results), but everything keyed off a final status silently misbehaved: bracket winners never advanced for manually-entered knockout results, and the knockout seeding card warned that the group stage was unfinished even with every result in. - storeResult now promotes scheduled/postponed games to Full Time before saving the result, so observers (bracket advancement, completeness checks) see a final game; in-progress games are left alone — the editor is a correction tool there - one-off migration backfills full_time onto already-recorded games, via the query builder so no broadcasts or advancement fire mid-migration Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a two-entry-paths inconsistency surfaced while reviewing the knockout seeding warning (#50): the manual result editor recorded the score but never touched the game's status, so played games sat at
scheduledforever. Standings looked fine (they read results), but everything keyed off a final status silently misbehaved:AdvanceBracketWinnernever promoted winners for manually-entered knockout resultsscheduledwith results attached)Changes
storeResultpromotesscheduled/postponedgames toFull Timebefore saving the result, so the observer chain sees a final game and bracket advancement fires. Live/half-time/cancelled games are untouched — the editor is a correction tool there, not a way to end a match.full_timeon already-recorded games (query builder on purpose: no broadcasts / advancement side-effects mid-migration). Irreversible by design.Independent of #49/#50 — branched off main, can merge in any order.
Testing
full_time🤖 Generated with Claude Code