Fix HTML formatting and update normative changes#387
Conversation
Makes list items end consistently with `.`, and makes some tab indents into space indents, to match the majority of existing indents.
| <li><a href="https://www.w3.org/2013/sparql-errata#errata-query-23">errata-query-23</a>: Fix inconsistenties between <a href="#defn_aggMin">MIN</a> and <a | ||
| href="#defn_aggMax">MAX</a></li> | ||
| <li><a href="https://www.w3.org/2013/sparql-errata#editorial-query-1">editorial-query-1</a>: | ||
| Missing right parenthesis in <a href="#defn_evalGraph">Evaluation of Graph definition</a></li> |
There was a problem hiding this comment.
and makes some tab indents into space indents
This PR introduces tabs.
cat -A:
+^I^I^I^I Missing right parenthesis in <a href="#defn_evalGraph">Evaluation of Graph definition</a></li>$
Please replace with spaces.
Indent in the document is 2 spaces per level.
There was a problem hiding this comment.
Very strange. I know for a fact I did not type any tabs; part of the point of this PR was to replace tabs with spaces! It seems that GitHub "helped" me.
I did indent the <li> content with 4 spaces, because it made for clearer viewing, but I have backed those off to 2 spaces now.
There was a problem hiding this comment.
Please check "Files changed".
They are now extensive changes - yes, the doc has sporadic tabs; if the intention is to change these, then do it while retaining layout.
The <li> you changed are 4 spaces, including in the editorial changes section where it was correct.
When opening this file, GitHub changed my edit settings from spaces to tabs, and from 4 to 2. I manually changed these back, and did a regex search for `\i`. There were scattered tabs throughout, as well as the concentration around line `13100`. I believe they've all *really* been cleaned now, and won't switch back.
| <ul> | ||
| <li>Update grammar for triple terms, reifiers, reified triples, annotation syntax, and triple term functions | ||
| in <a href="#sparqlGrammar" class="sectionRef"></a></li> | ||
| in <a href="#sparqlGrammar" class="sectionRef"></a>.</li> |
| syntax as links to their respective definition; similarly, mark up all | ||
| mentions of operators of the <a href="#sparqlAlgebra">SPARQL algebra</a> | ||
| as links to their respective definition</li> | ||
| (<a href="#algebraicSyntax" class="sectionRef"></a>) into which the AST |
There was a problem hiding this comment.
This was correct, now there is 4 space indent.
There was a problem hiding this comment.
I may scream. A lot. GitHub has done the "helpful" thing of forbidding pull request authors from requesting changes on their own pull request. So I have 58 pending comments which request changes, fixing the now-incorrect space runs. Which I think I can apply through an edit on my branch, manually copying each now-comment line from this review. They were applicable, one-by-one, not in a batch, so this will need a squash-merge. But I think it's ready now.
|
@afs — I hope I've gotten them all right this time. |
|
Look at the "File changes". Is that what you want to change throughout the document? Grammar: Lines 12050-12685 FYI: The PR is now 60 commits which is 60 lines of log messages. These will need squashing. |
I want to eliminate
I would like to improve the grammar section (by eliminating tabs therein, among whatever other changes are currently in this PR) by whatever means is necessary. There is no marker of which I'm aware, informing reviewers that the grammar section is machine generated. This seems to me to be a problem. At minimum, I hope it is possible to tell me how to submit change requests against the generator such that the changes I've suggested for its output are applied.
Yes. I believe I commented to that effect (squash commit will be needed) in one of the earlier commits now in this PR. This need results from the fact that GitHub no longer lets the author of a PR submit a change request on that PR; only comments. I suppose I could have started with the whole document, put it in a text editor, made all the changes I wanted, copied all that text, and overwritten the document I started with as one commit, changing the same 60ish lines. I'm really not trying to make your, my, nor anyone else's life more difficult. I'd be happy to work on this within a concall of whatever shape, if that would help you. |
|
All the grammar tables for all the languages are machine generated, and machine checked. |
|
Inline notation of such machine generation tends to be helpful in preventing human-generated change suggestions. Reject what you will, accept what you will. I would appreciate some sort of comment on each rejected change suggestions, even if it's simply "machine generated artefact" or the like. |
It isn't practical to work through the individual commits one-by-one. A separate PR for just the alternations to the "Changes" section - the semantic changes! - would be helpful. |
|
I do wish you'd have requested this before I produced this PR. I'll try to satisfy this new revision request in the next few days. |
The original description was
except the PR added tabs and misaligned text. I asked:
Your second commit blames the tools. |
|
Rereading the history, I see a case of several misunderstandings, and yes, some blame for the tools in GitHub's web-interface. I believe I understand your frustration with what I've been sending. I'm not going to try to explain my frustration, because I think that would lead to further misunderstandings. I believe I see a path to relatively quick production of —
— which I expect to be one commit each. If all goes to plan, they'll be done tomorrow. |
4 participants
Makes list items end consistently with
., and makes some tab indents into space indents, to match the majority of existing indents.Fixes #386.
Preview | Diff