Restrict use of SELECT * in queries with implicit grouping.#379
Conversation
|
This doesn't (yet) add to the changelog. I would assume this would count as a normative change, although I think this aligns with the intent of the original 1.1 language. |
|
@hartig @rubensworks – any thoughts on the changelog? Do you agree this would be a normative change, and if so, can I assume your approval here would include listing it as such in the changelog? |
|
Yes. The two sections touched by this PR are normative and, for some engines, the change may result in adaptations to achieve conformance. |
|
Yes, I agree it would be good to add this to the changelog (no additional approval from me is needed).
Yes. At least in our implementation, this will require a (small) change. |
Also, remove trailing dot on changelog items to improve consistency.
|
Added this to the list of normative changes. Also improved consistency of the changelog list items so that they all omit a trailing dot. |
|
@rubensworks sorry, bad manipulation in GitHub UI. No need to re-review this MR |
FWIW Jena does not consider this a normative change. |
| <li>Define parser input as being an | ||
| <a data-cite="RDF12-CONCEPTS#dfn-rdf-string">RDF string</a>. | ||
| Exclude Unicode surrogates from Unicode escape sequences.</li> | ||
| Exclude Unicode surrogates from Unicode escape sequences</li> |
There was a problem hiding this comment.
I believe this should be 2 list items, not 1. On that basis, a dot should be deleted (though I disagree with this practice when (some of) the list items are complete sentences, on which basis some other list items should be edited).
| <li>Define parser input as being an | |
| <a data-cite="RDF12-CONCEPTS#dfn-rdf-string">RDF string</a>. | |
| Exclude Unicode surrogates from Unicode escape sequences.</li> | |
| Exclude Unicode surrogates from Unicode escape sequences</li> | |
| <li>Define parser input as being an | |
| <a data-cite="RDF12-CONCEPTS#dfn-rdf-string">RDF string</a></li> | |
| <li>Exclude Unicode surrogates from Unicode escape sequences</li> |
| @@ -12893,13 +12900,14 @@ <h2>Changes between SPARQL 1.1 Query Language and SPARQL 1.2 Query Language</h2> | |||
| for details. | |||
There was a problem hiding this comment.
This is the third complete sentence in this list item. I agree that it should end with a dot. But for consistency, all list items should end with dots, and for best consistency all list items should be written as complete sentences (which I believe most to be already).
There was a problem hiding this comment.
@TallTed – This has already been merged. A new PR is probably the best approach for the changes you suggested here and above.
Closes #378.
Preview | Diff