Skip to content

Restrict use of SELECT * in queries with implicit grouping.#379

Merged
kasei merged 2 commits into
mainfrom
gtw-agg-proj-star
May 21, 2026
Merged

Restrict use of SELECT * in queries with implicit grouping.#379
kasei merged 2 commits into
mainfrom
gtw-agg-proj-star

Conversation

@kasei

@kasei kasei commented May 18, 2026

Copy link
Copy Markdown
Contributor

Closes #378.


Preview | Diff

@kasei

kasei commented May 18, 2026

Copy link
Copy Markdown
Contributor Author

This doesn't (yet) add to the changelog. I would assume this would count as a normative change, although I think this aligns with the intent of the original 1.1 language.

@kasei kasei requested review from Tpt, afs, hartig and rubensworks May 18, 2026 19:32
@kasei

kasei commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

@hartig @rubensworks – any thoughts on the changelog? Do you agree this would be a normative change, and if so, can I assume your approval here would include listing it as such in the changelog?

@hartig

hartig commented May 19, 2026

Copy link
Copy Markdown
Contributor

Yes. The two sections touched by this PR are normative and, for some engines, the change may result in adaptations to achieve conformance.

@rubensworks

Copy link
Copy Markdown
Member

Yes, I agree it would be good to add this to the changelog (no additional approval from me is needed).

Do you agree this would be a normative change

Yes. At least in our implementation, this will require a (small) change.

Also, remove trailing dot on changelog items to improve consistency.
@kasei

kasei commented May 20, 2026

Copy link
Copy Markdown
Contributor Author

Added this to the list of normative changes. Also improved consistency of the changelog list items so that they all omit a trailing dot.

@Tpt Tpt requested a review from rubensworks May 21, 2026 16:15
@Tpt

Tpt commented May 21, 2026

Copy link
Copy Markdown
Contributor

@rubensworks sorry, bad manipulation in GitHub UI. No need to re-review this MR

@afs

afs commented May 21, 2026

Copy link
Copy Markdown
Contributor

Do you agree this would be a normative change,

FWIW Jena does not consider this a normative change.
It treats aggregate syntax as meaning a query has a GROUP BY.

@kasei kasei merged commit 0f3cf2d into main May 21, 2026
2 checks passed
Comment thread spec/index.html
Comment on lines 12892 to +12894
<li>Define parser input as being an
<a data-cite="RDF12-CONCEPTS#dfn-rdf-string">RDF string</a>.
Exclude Unicode surrogates from Unicode escape sequences.</li>
Exclude Unicode surrogates from Unicode escape sequences</li>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should be 2 list items, not 1. On that basis, a dot should be deleted (though I disagree with this practice when (some of) the list items are complete sentences, on which basis some other list items should be edited).

Suggested change
<li>Define parser input as being an
<a data-cite="RDF12-CONCEPTS#dfn-rdf-string">RDF string</a>.
Exclude Unicode surrogates from Unicode escape sequences.</li>
Exclude Unicode surrogates from Unicode escape sequences</li>
<li>Define parser input as being an
<a data-cite="RDF12-CONCEPTS#dfn-rdf-string">RDF string</a></li>
<li>Exclude Unicode surrogates from Unicode escape sequences</li>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to issue #386 and pr #387

Comment thread spec/index.html
@@ -12893,13 +12900,14 @@ <h2>Changes between SPARQL 1.1 Query Language and SPARQL 1.2 Query Language</h2>
for details.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the third complete sentence in this list item. I agree that it should end with a dot. But for consistency, all list items should end with dots, and for best consistency all list items should be written as complete sentences (which I believe most to be already).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TallTed – This has already been merged. A new PR is probably the best approach for the changes you suggested here and above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider adding syntactic restrictions on SELECT * on grouped queries

7 participants