Feat/handling authorization header leaks to third party servers on redirect #8380
+543
−24
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,4 +34,138 @@ describe('makeAxiosInstance', () => { | |
|
|
||
| expect(stubAdapter.getConfig().headers['User-Agent']).toMatch(/^bruno-runtime\//); | ||
| }); | ||
|
|
||
| describe('cross-origin redirects authorization stripping', () => { | ||
| function createRedirectingStubAdapter(redirectUrl, redirectStatus = 302) { | ||
| const calls = []; | ||
| const adapter = (config) => { | ||
| calls.push(config); | ||
| if (calls.length === 1) { | ||
| const err = new Error('Redirect ' + redirectStatus); | ||
| err.config = config; | ||
| err.response = { | ||
| status: redirectStatus, | ||
| statusText: 'Found', | ||
| headers: { | ||
| location: redirectUrl | ||
| }, | ||
| data: {} | ||
| }; | ||
| return Promise.reject(err); | ||
| } | ||
| return Promise.resolve({ | ||
| data: { success: true }, | ||
| status: 200, | ||
| statusText: 'OK', | ||
| headers: {}, | ||
| config | ||
| }); | ||
| }; | ||
| adapter.getCalls = () => calls; | ||
| return adapter; | ||
| } | ||
|
|
||
| it('should strip Authorization and Proxy-Authorization headers on cross-origin redirect when forwardAuthorizationHeader is false', async () => { | ||
| const stubAdapter = createRedirectingStubAdapter('https://other-domain.com/target'); | ||
| const instance = makeAxiosInstance({ | ||
| followRedirects: true, | ||
| forwardAuthorizationHeader: false | ||
| }); | ||
|
|
||
| await instance({ | ||
| url: 'https://api.example.com/start', | ||
| method: 'get', | ||
| headers: { | ||
| 'Authorization': 'Bearer my-token', | ||
| 'Proxy-Authorization': 'Bearer proxy-token', | ||
| 'Custom-Header': 'keep-me' | ||
| }, | ||
| adapter: stubAdapter | ||
| }); | ||
|
|
||
| const calls = stubAdapter.getCalls(); | ||
| expect(calls.length).toBe(2); | ||
|
|
||
| // First call should have headers | ||
| expect(calls[0].headers['Authorization']).toBe('Bearer my-token'); | ||
| expect(calls[0].headers['Proxy-Authorization']).toBe('Bearer proxy-token'); | ||
| expect(calls[0].headers['Custom-Header']).toBe('keep-me'); | ||
|
|
||
| // Redirected call should strip auth headers but keep custom headers | ||
| expect(calls[1].headers['Authorization']).toBeUndefined(); | ||
| expect(calls[1].headers['Proxy-Authorization']).toBeUndefined(); | ||
| expect(calls[1].headers['Custom-Header']).toBe('keep-me'); | ||
|
Contributor
There was a problem hiding this comment. also add expect(calls[1].url).toBe('https://other-domain.com/target'); |
||
| }); | ||
|
|
||
| it('should preserve Authorization and Proxy-Authorization headers on cross-origin redirect when forwardAuthorizationHeader is true', async () => { | ||
| const stubAdapter = createRedirectingStubAdapter('https://other-domain.com/target'); | ||
| const instance = makeAxiosInstance({ | ||
| followRedirects: true, | ||
| forwardAuthorizationHeader: true | ||
| }); | ||
|
|
||
| await instance({ | ||
| url: 'https://api.example.com/start', | ||
| method: 'get', | ||
| headers: { | ||
| 'authorization': 'Bearer my-token', | ||
| 'proxy-authorization': 'Bearer proxy-token', | ||
| 'Custom-Header': 'keep-me' | ||
| }, | ||
| adapter: stubAdapter | ||
| }); | ||
|
|
||
| const calls = stubAdapter.getCalls(); | ||
| expect(calls.length).toBe(2); | ||
| expect(calls[1].headers['authorization']).toBe('Bearer my-token'); | ||
| expect(calls[1].headers['proxy-authorization']).toBe('Bearer proxy-token'); | ||
| expect(calls[1].headers['Custom-Header']).toBe('keep-me'); | ||
| }); | ||
|
|
||
| it('should preserve Authorization and Proxy-Authorization headers on same-origin redirect even if forwardAuthorizationHeader is false', async () => { | ||
| const stubAdapter = createRedirectingStubAdapter('https://api.example.com/target'); | ||
| const instance = makeAxiosInstance({ | ||
| followRedirects: true, | ||
| forwardAuthorizationHeader: false | ||
| }); | ||
|
|
||
| await instance({ | ||
| url: 'https://api.example.com/start', | ||
| method: 'get', | ||
| headers: { | ||
| 'Authorization': 'Bearer my-token', | ||
| 'Proxy-Authorization': 'Bearer proxy-token' | ||
| }, | ||
| adapter: stubAdapter | ||
| }); | ||
|
|
||
| const calls = stubAdapter.getCalls(); | ||
| expect(calls.length).toBe(2); | ||
| expect(calls[1].headers['Authorization']).toBe('Bearer my-token'); | ||
| expect(calls[1].headers['Proxy-Authorization']).toBe('Bearer proxy-token'); | ||
| }); | ||
|
|
||
| it('should preserve Authorization and Proxy-Authorization headers on relative redirect even if forwardAuthorizationHeader is false', async () => { | ||
| const stubAdapter = createRedirectingStubAdapter('/relative-target'); | ||
| const instance = makeAxiosInstance({ | ||
| followRedirects: true, | ||
| forwardAuthorizationHeader: false | ||
| }); | ||
|
|
||
| await instance({ | ||
| url: 'https://api.example.com/start', | ||
| method: 'get', | ||
| headers: { | ||
| 'Authorization': 'Bearer my-token', | ||
| 'Proxy-Authorization': 'Bearer proxy-token' | ||
| }, | ||
| adapter: stubAdapter | ||
| }); | ||
|
|
||
| const calls = stubAdapter.getCalls(); | ||
| expect(calls.length).toBe(2); | ||
| expect(calls[1].headers['Authorization']).toBe('Bearer my-token'); | ||
| expect(calls[1].headers['Proxy-Authorization']).toBe('Bearer proxy-token'); | ||
| }); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we please change the name to something like forwardAuthorizationOnRedirect or shouldForwardAuthorizationHeader?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Earlier it was named
forwardAuthorizationOnRedirectbut after discussing with Bijin and Anoop,forwardAuthorizationHeaderwas finalised yesterday.