Feat/handling authorization header leaks to third party servers on redirect#8380
Draft
Gopi-bruno wants to merge 2 commits into
Conversation
…ensitive headers on cross-origin redirects
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the
forwardAuthorizationOnRedirectsetting to prevent sensitive authentication headers (AuthorizationandProxy-Authorization) from leaking to third-party/cross-origin servers during redirects.Key Changes:
bruno-cliandbruno-electron).forwardAuthorizationOnRedirectis set tofalse, the sensitiveAuthorizationandProxy-Authorizationheaders are stripped before following the redirect.Forward Auth Headers on Redirecttoggle under the request settings pane.false(secure by default).true(backward-compatible) to preserve current workflows unless explicitly updated by the user.bruno-schema,bruno-schema-types, andbruno-lang(bruToJson.js) to support the new request property.bruno-convertersto support this setting on GraphQL and HTTP requests without modifying external dependency manifests.bruno-cli(packages/bruno-cli/tests/utils/axios-instance.spec.js) andbruno-electron(packages/bruno-electron/tests/network/axios-instance.spec.js) covering same-origin vs. cross-origin redirects with varying settings.tests/request/settings/redirect-auth-strip.spec.ts) using local redirect test routes.Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.
Credits
Special thanks to
@abhishek-brunofor the initial implementation and research of the cross-origin header stripping logic in #7578. This PR builds upon that implementation by adding the requested settings configuration for backward compatibility.