Skip to content

fix: don't call winterm for OSC title codes when not converting (#407) #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
patchwright wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −1
Open

fix: don't call winterm for OSC title codes when not converting (#407) #425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion colorama/ansitowin32.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,8 @@ def convert_osc(self, text):
# 1 - change icon (we don't support this)
# 2 - change title
if params[0] in '02':
winterm.set_title(params[1])
if self.convert and winterm:
winterm.set_title(params[1])
return text


Expand Down
9 changes: 9 additions & 0 deletions colorama/tests/ansitowin32_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,15 @@ def test_osc_codes(self):
stream.write(code)
self.assertEqual(winterm.set_title.call_count, 2)

def test_osc_codes_not_converted_when_stripping(self):
# Issue #407: with strip=True and convert=False (e.g. no PTY on Linux),
# OSC title sequences must be stripped without touching winterm, which
# is None on non-Windows platforms. Calling it would raise AttributeError.
mockStdout = Mock()
with patch('colorama.ansitowin32.winterm', None):
stream = AnsiToWin32(mockStdout, strip=True, convert=False)
stream.write('\033]2;colorama_test_title\x07') # must not raise

def test_native_windows_ansi(self):
with ExitStack() as stack:
def p(a, b):
Expand Down