fix: don't call winterm for OSC title codes when not converting (#407) - #425
Open
patchwright wants to merge 1 commit into
Open
fix: don't call winterm for OSC title codes when not converting (#407)#425patchwright wants to merge 1 commit into
patchwright wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #407.
Problem
In
convert_osc,winterm.set_title()is called unconditionally when an OSC title sequence is seen. Every other winterm call is gated onself.convert(convert_ansichecksif self.convert:,get_win32_callschecksself.convert and winterm) — but this one isn't.On non-Windows platforms
winterm is None. Whenstrip=Trueandconvert=False(e.g. running without a PTY on Linux, whereinit()strips sequences but does not convert), writing a title sequence reacheswinterm.set_titleand crashes:(call path as traced in #407 by the reporter.)
Fix
Guard the call with
self.convert and winterm, matching the pattern already used inget_win32_calls. The OSC sequence is still stripped from the output in all cases (that happens before the guard); only the win32 title call is now correctly skipped when not converting.Tests
Added
test_osc_codes_not_converted_when_stripping: withwintermpatched toNoneandstrip=True, convert=False, writing a title OSC sequence must not raise. It fails onmainwith the exact AttributeError above and passes with the fix. Existingtest_osc_codes(theconvert=Truepath) is unchanged. Full suite: 39 passed, 14 skipped.