Repository navigation
fix: remove faulty reward-cycle-to-unlock-height - #7232
Closed
brice-stacks wants to merge 12 commits into
Closed
brice-stacks wants to merge 12 commits into
brice-stacks wants to merge 12 commits into
Conversation
The simnet doesn't provide a way to do much real testing with the L1 data, so we need to remove those from the unit tests and check that behavior in integration tests.
The `construct-lockup-script` now correctly handles the `unlock-bytes` from the user. The `check_pox_5_register_for_bond_l1_lockup_lifecycle` test is extended to verify that the staker, and no one else, can spend the BTC when the lock expires.
hstove-stacks
approved these changes
May 27, 2026
hstove-stacks
left a comment
hstove-stacks
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Note that I've just reviewed this last commit, not #7223
Contributor
Author
|
This has been integrated into #7249 |
|
Closed PR has been locked after 14 days of inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on top of #7223; only the last commit is new.