Repository navigation
fix: prevent counting duplicate lockups in pox-5 - #7233
Merged
brice-stacks merged 9 commits intoJun 3, 2026
Merged
brice-stacks merged 9 commits into
brice-stacks merged 9 commits into
Conversation
brice-stacks
requested review from
Copilot,
hstove-stacks and
rob-stacks
and removed request for
hstove-stacks
May 27, 2026 13:15
hstove-stacks
self-requested a review
May 27, 2026 21:43
hstove-stacks
requested changes
May 27, 2026
hstove-stacks
left a comment
hstove-stacks
left a comment
Contributor
There was a problem hiding this comment.
Oh also, it looks like the Clarigen types are off - can you run npx clarigen?
Contributor
Author
|
this is still based on top of #7223 |
Simnet does not support the bitcoin data enough to allow us to get to the thing we want to test for in the code, so we remove the unit test and add the check to an integration test.
Contributor
Author
Clarigen is updated in 2f1cfaf |
Coverage Report for CI Build 26399134379Coverage increased (+0.02%) to 85.974%Details
Uncovered Changes
Coverage Regressions6122 previously-covered lines in 96 files lost coverage.
Coverage Stats
💛 - Coveralls |
Contributor
Author
|
I took a look at that failing sip-31 prop test. It is definitely unrelated and it looks like just a test flakiness. Opened #7251. |
hstove-stacks
approved these changes
May 29, 2026
rob-stacks
approved these changes
Jun 3, 2026
brice-stacks
merged commit Jun 3, 2026
368474a
into
stacks-network:pox-wf-integration
207 of 216 checks passed
|
Closed PR has been locked after 14 days of inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #7232; just the last commit is new.