Skip to content

Remove Note from plainify output#3

Merged
srid merged 7 commits into
srid:masterfrom
TristanCacqueray:plainify-without-notes
Mar 25, 2024
Merged

Remove Note from plainify output#3
srid merged 7 commits into
srid:masterfrom
TristanCacqueray:plainify-without-notes

Conversation

@TristanCacqueray

@TristanCacqueray TristanCacqueray commented Mar 25, 2024

Copy link
Copy Markdown
Contributor

See: srid/emanote#529

TODO(@srid)

  • Add tests (Add tests #1) in master branch
  • Add plainify tests in this PR
  • Refactor

Comment thread src/Commonmark/Extensions/WikiLink.hs
@srid

srid commented Mar 25, 2024

Copy link
Copy Markdown
Owner

I'll try to initialize some tests (#1) in the master branch. Then, we can add tests for this change before merging it.

@srid

srid commented Mar 25, 2024

Copy link
Copy Markdown
Owner

I noticed that plainify'ication of regular links are broken, hence that test is disabled. Let's address this in different PR.

@srid
srid merged commit 57dcf66 into srid:master Mar 25, 2024
@srid

srid commented Mar 25, 2024

Copy link
Copy Markdown
Owner

May need follow-up fix for srid/emanote#529 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants