Ignore note in plainify#7
Closed
TristanCacqueray wants to merge 3 commits into
Closed
Conversation
TristanCacqueray
marked this pull request as draft
March 25, 2024 15:53
Contributor
Author
|
This seems to work better: srid/commonmark-wikilink#3 |
Owner
|
Do we still need this PR? (Will take a look at other changes latter) |
Contributor
Author
|
If the approach in commonmark-wikilink works for you, then we should import the impl here and fix the todo in wikilink to extend on heist-extra. |
Owner
|
Maybe heist-extra should just get |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in srid/emanote#529