-
Notifications
You must be signed in to change notification settings - Fork 37
ROMAN-4156: Add MSOS L4 detection efficiency catalog schema #838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alexstuk
wants to merge
6
commits into
spacetelescope:main
Choose a base branch
from
alexstuk:ROMAN-4156-detection-efficiency-catalog
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3c7fcbe
Create wfi_microlensing_detection_efficiency_catalog_level_4.yaml
alexstuk 781e60d
symlink and pyproject update
alexstuk 56cdec4
ROMAN-4866 Add detection efficiency archive metadata keys
alexstuk 74ea6c0
Resolve detection efficiency pyproject conflict
alexstuk 6aafb09
Merge upstream main into detection efficiency branch
alexstuk 9e8e903
Add detection efficiency changelog fragment
alexstuk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Add the SSC MSOS Level 4 detection efficiency catalog schema. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| %YAML 1.1 | ||
| --- | ||
| $schema: asdf://stsci.edu/datamodels/roman/schemas/rad_schema-2.0.0 | ||
| id: asdf://stsci.edu/datamodels/roman/schemas/SSC/MSOS/keywords/msos_detection_efficiency-1.0.0 | ||
|
|
||
| title: MSOS detection efficiency keywords | ||
| extName: SSC | ||
| type: object | ||
| properties: | ||
| inject_medium: | ||
| title: Injection Medium | ||
| description: Detection efficiency injection medium represented by the rows in this file. | ||
| type: string | ||
| maxLength: 16 | ||
| enum: | ||
| - images | ||
| - lightcurve | ||
| - rhie | ||
| archive_catalog: | ||
| datatype: nvarchar(16) | ||
| destination: [WFIMSOSCatalog.inject_medium] | ||
| tp_count: | ||
| title: True Positive Count | ||
| description: Number of rows in this file with BinaryClass equal to TP. | ||
| type: integer | ||
| minimum: 0 | ||
| archive_catalog: | ||
| datatype: int | ||
| destination: [WFIMSOSCatalog.tp_count] | ||
| fp_count: | ||
| title: False Positive Count | ||
| description: Number of rows in this file with BinaryClass equal to FP. | ||
| type: integer | ||
| minimum: 0 | ||
| archive_catalog: | ||
| datatype: int | ||
| destination: [WFIMSOSCatalog.fp_count] | ||
| tn_count: | ||
| title: True Negative Count | ||
| description: Number of rows in this file with BinaryClass equal to TN. | ||
| type: integer | ||
| minimum: 0 | ||
| archive_catalog: | ||
| datatype: int | ||
| destination: [WFIMSOSCatalog.tn_count] | ||
| fn_count: | ||
| title: False Negative Count | ||
| description: Number of rows in this file with BinaryClass equal to FN. | ||
| type: integer | ||
| minimum: 0 | ||
| archive_catalog: | ||
| datatype: int | ||
| destination: [WFIMSOSCatalog.fn_count] | ||
|
|
||
| required: [inject_medium, tp_count, fp_count, tn_count, fn_count] |
13 changes: 13 additions & 0 deletions
13
latest/SSC/MSOS/wfi_microlensing_detection_efficiency_catalog_level_4.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| %YAML 1.1 | ||
| --- | ||
| $schema: asdf://stsci.edu/datamodels/roman/schemas/rad_schema-2.0.0 | ||
| id: asdf://stsci.edu/datamodels/roman/schemas/SSC/MSOS/wfi_microlensing_detection_efficiency_catalog_level_4-1.0.0 | ||
|
|
||
| title: GBTDS Level 4 Microlensing Detection Efficiency Catalog | ||
| archive_meta: Science WFI Level 4 MSOS Detection Efficiency Catalog | ||
| type: object | ||
| allOf: | ||
| - $ref: asdf://stsci.edu/datamodels/roman/schemas/SSC/ssc_basic-1.0.0 | ||
| - $ref: asdf://stsci.edu/datamodels/roman/schemas/SSC/MSOS/keywords/msos_basic-1.0.0 | ||
| - $ref: asdf://stsci.edu/datamodels/roman/schemas/SSC/MSOS/keywords/msos_common-1.0.0 | ||
| - $ref: asdf://stsci.edu/datamodels/roman/schemas/SSC/MSOS/keywords/msos_detection_efficiency-1.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
src/rad/resources/schemas/SSC/MSOS/keywords/msos_detection_efficiency-1.0.0.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../../../../../../latest/SSC/MSOS/keywords/msos_detection_efficiency.yaml |
1 change: 1 addition & 0 deletions
1
...sources/schemas/SSC/MSOS/wfi_microlensing_detection_efficiency_catalog_level_4-1.0.0.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../../../../../latest/SSC/MSOS/wfi_microlensing_detection_efficiency_catalog_level_4.yaml |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slight difference in naming of this file vs what we called it in the interface
wfi_microlensing_detection_efficiency_catalog_level_4 (this file)
wfi_microlensing_detection_efficiency_product_level_4 (interface)
Nothing will break, so not a huge deal. If "catalog" is truly better than "product" we can migrate the interface naming in the future, but not high priority.