ROMAN-4156: Add MSOS L4 detection efficiency catalog schema#838
ROMAN-4156: Add MSOS L4 detection efficiency catalog schema#838alexstuk wants to merge 6 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #838 +/- ##
==========================================
- Coverage 86.56% 86.03% -0.54%
==========================================
Files 15 15
Lines 1154 1131 -23
==========================================
- Hits 999 973 -26
- Misses 155 158 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Is there an update to this ticket? |
|
SSC is under AT period - Jen will get back to this asap. |
|
Is this intended to be in the intermediate release? If so, we need this done and fully approved by COB Thursday. |
detection efficiency is a commissioning product, so no we are not trying to get this into the intermediate release. |
Add Detection Efficiency-specific RAD metadata for the Level 4 MSOS Detection Efficiency Catalog. The original PR only wired the product to the shared MSOS metadata blocks. This update adds a dedicated MSOS Detection Efficiency keyword block with archive-queryable fields for: - inject_medium - tp_count - fp_count - tn_count - fn_count The TP/FP/TN/FN values are represented as file-level row counts, matching the expected final product behavior where BinaryClass remains a row-level catalog column. The Detection Efficiency catalog schema now references the shared MSOS basic/program/settings metadata plus the new DE-specific keyword block. The spatial region block was removed because the DE catalog does not have a clear file-level sky footprint requirement, and similar MSOS L4 catalog products do not all require s_region.
|
Updated to include DE-specific metadata for |
RAD Archive Diff ReportGenerated: 2026-06-11 19:07:46Z Summary
Roman — db fields to addRoman — db fields to modifyRoman — db fields to removeRita — db fields to addRita — db fields to modifyRita — db fields to removeDatatype changes by destination |
WilliamJamieson
left a comment
There was a problem hiding this comment.
Could you add a change log fragment, see
rad/.github/pull_request_template.md
Lines 27 to 33 in 666cc52
|
Thanks for the review. I added the changelog fragment for the detection efficiency schema addition. |
There was a problem hiding this comment.
Slight difference in naming of this file vs what we called it in the interface
wfi_microlensing_detection_efficiency_catalog_level_4 (this file)
wfi_microlensing_detection_efficiency_product_level_4 (interface)
Nothing will break, so not a huge deal. If "catalog" is truly better than "product" we can migrate the interface naming in the future, but not high priority.
Resolves N/A (external ticket: ROMAN-4156)
Closes # N/A
This PR adds a new MSOS Level 4 Detection Efficiency catalog schema:
latest/SSC/MSOS/wfi_microlensing_detection_efficiency_catalog_level_4.yamlTo wire this schema into RAD packaging/validation, this PR also:
src/rad/resources/schemas/SSC/MSOS/wfi_microlensing_detection_efficiency_catalog_level_4-1.0.0.yamlpyproject.toml:asdf_schema_xfail_testsTasks
radtests.docs/page.no-changelog-entry-needed.)changes/.I do not have maintainer permissions in
spacetelescope/rad; maintainers may need to apply labels and run org-side workflow steps.