Skip to content

fix(coinmarketcap): scope crypto batch requests to their own quote currency #5140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tyrion70 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

fix(coinmarketcap): scope crypto batch requests to their own quote currency #5140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/coinmarketcap-crypto-quote-filter.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@chainlink/coinmarketcap-adapter': patch
---

Fix crypto transport attaching the full param list to every per-quote request, which caused intermittent 502 "Data for quote X not found" for any param whose quote differed from the request's convert.
2 changes: 1 addition & 1 deletion packages/sources/coinmarketcap/src/transport/crypto.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ export const httpTransport = new HttpTransport<HttpTransportTypes>({
const uniqueQuotes = [...new Set(list.map((p) => p.quote.toUpperCase()))]
uniqueQuotes.forEach((uniqueQuote) => {
requests.push({
params: list,
params: list.filter((p) => p.quote.toUpperCase() === uniqueQuote),
request: {
baseURL: settings.API_ENDPOINT,
url: '/cryptocurrency/quotes/latest',
Expand Down