fix(coinmarketcap): scope crypto batch requests to their own quote currency#5140
Open
tyrion70 wants to merge 1 commit into
Open
fix(coinmarketcap): scope crypto batch requests to their own quote currency#5140tyrion70 wants to merge 1 commit into
tyrion70 wants to merge 1 commit into
Conversation
…rrency The crypto transport builds one HTTP request per unique quote currency (convert=<quote>) but tags each request with the full param list across all quotes. parseResponse then looks up data.quote[p.quote] for every attached param, so any param whose quote differs from the request's convert returns a spurious 502 "Data for quote X not found". Because each param is attached to every per-quote request, the per-param reconciliation is order-dependent and the failing set is non-deterministic and key-independent. Filter each request's params down to the params sharing its quote, so each param is resolved only by the request that requested its convert. One line; no behavioural change for single-quote batches. Signed-off-by: Peter van Mourik <peter@chainlayer.io>
🦋 Changeset detectedLatest commit: 2bb335d The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symptom: coinmarketcap crypto feeds intermittently return 502 "Data for quote "" was not found in response"; the failing set is non-deterministic, reshuffles on restart, and is independent of API key/plan.
Cause: In crypto.ts one HTTP request is built per unique quote (convert=), but each is tagged with params: list — the entire param set across all quotes. parseResponse then looks up data.quote[p.quote] for every attached param, so any param whose quote ≠ the request's convert 502s.
Fix: Filter each request's params down to the params sharing its quote, so each param is resolved only by the request that actually requested its convert. One line; no behavioural change for single-quote batches.