SF-3882 Remove SMT Translation Suggestions

src/RealtimeServer/scriptureforge/models/sf-project-user-config-test-data.ts

@@ -10,7 +10,7 @@ export function createTestProjectUserConfig(overrides?: RecursivePartial<SFProje
     isTargetTextRight: false,
     confidenceThreshold: 0.2,
     transliterateBiblicalTerms: false,
-    translationSuggestionsEnabled: true,
+    translationSuggestionsEnabled: false,
     numSuggestions: 1,
     selectedSegment: '',
     questionRefsRead: [],

src/RealtimeServer/scriptureforge/services/note-thread-service.spec.ts

@@ -367,8 +367,7 @@ class TestEnvironment {
       getSFProjectUserConfigDocId('project01', this.commenterId),
       createTestProjectUserConfig({
         projectRef: 'project01',
-        ownerRef: this.commenterId,
-        translationSuggestionsEnabled: false
+        ownerRef: this.commenterId
       })
     );
 

src/SIL.XForge.Scripture/ClientApp/package.json

@@ -55,7 +55,6 @@
     "@sillsdev/lynx": "^0.3.5",
     "@sillsdev/lynx-delta": "^0.2.4",
     "@sillsdev/lynx-punctuation-checker": "^0.2.0",
-    "@sillsdev/machine": "^2.4.2",
     "@sillsdev/scripture": "1.4.1",
     "angular-file": "^4.0.2",
     "angular-split": "^16.2.1",

src/SIL.XForge.Scripture/ClientApp/src/app/checking/checking/checking-answers/checking-question/checking-question.stories.ts

@@ -24,8 +24,7 @@ const query: RealtimeQuery<TextAudioDoc> = mock(RealtimeQuery<TextAudioDoc>);
 const projectUserConfigDoc: SFProjectUserConfigDoc = mock(SFProjectUserConfigDoc);
 const projectUserConfig: SFProjectUserConfig = createTestProjectUserConfig({
   projectRef: 'project01',
-  ownerRef: 'user01',
-  translationSuggestionsEnabled: false
+  ownerRef: 'user01'
 });
 const textAudioDoc: TextAudioDoc = mock(TextAudioDoc);
 const textAudio: TextAudio = {

src/SIL.XForge.Scripture/ClientApp/src/app/checking/checking/checking-questions/checking-questions.component.ts

@@ -38,7 +38,6 @@ import { QuestionDoc } from '../../../core/models/question-doc';
 import { SFProjectProfileDoc } from '../../../core/models/sf-project-profile-doc';
 import { SFProjectUserConfigDoc } from '../../../core/models/sf-project-user-config-doc';
 import { SFProjectService } from '../../../core/sf-project.service';
-import { TranslationEngineService } from '../../../core/translation-engine.service';
 import { BookChapter, bookChapterMatchesVerseRef, CheckingUtils } from '../../checking.utils';
 import { CheckingQuestionsService } from '../checking-questions.service';
 
@@ -155,7 +154,6 @@ export class CheckingQuestionsComponent implements OnInit, OnChanges {
   constructor(
     private readonly questionsService: CheckingQuestionsService,
     private readonly userService: UserService,
-    private readonly translationEngineService: TranslationEngineService,
     private readonly changeDetector: ChangeDetectorRef,
     private readonly projectService: SFProjectService,
     private readonly i18n: I18nService,
@@ -472,16 +470,6 @@ export class CheckingQuestionsComponent implements OnInit, OnChanges {
     if (this._projectUserConfigDoc != null && this._projectUserConfigDoc.data != null) {
       const activeQuestionDoc = this.activeQuestionDoc;
       if (activeQuestionDoc != null && activeQuestionDoc.data != null) {
-        if (
-          this.project != null &&
-          this.project.translateConfig.translationSuggestionsEnabled &&
-          this.project.translateConfig.source !== undefined
-        ) {
-          await this.translationEngineService.trainSelectedSegment(
-            this._projectUserConfigDoc.data,
-            this.project.translateConfig.source.projectRef
-          );
-        }
         await this._projectUserConfigDoc.submitJson0Op(op => {
           op.set(puc => puc.selectedQuestionRef!, activeQuestionDoc.id);
           op.unset(puc => puc.selectedSegment);

src/SIL.XForge.Scripture/ClientApp/src/app/checking/checking/checking.component.spec.ts

@@ -75,7 +75,6 @@
 import { TextAudioDoc } from '../../core/models/text-audio-doc';
 import { TextDoc } from '../../core/models/text-doc';
 import { SFProjectService } from '../../core/sf-project.service';
-import { TranslationEngineService } from '../../core/translation-engine.service';
 import { AudioRecorderDialogComponent } from '../../shared/audio-recorder-dialog/audio-recorder-dialog.component';
 import { AudioPlayerComponent } from '../../shared/audio/audio-player/audio-player.component';
 import { AudioTimePipe } from '../../shared/audio/audio-time-pipe';
@@ -103,7 +102,6 @@
 
 const mockedUserService = mock(UserService);
 const mockedProjectService = mock(SFProjectService);
-const mockedTranslationEngineService = mock(TranslationEngineService);
 const mockedNoticeService = mock(NoticeService);
 const mockedActivatedRoute = mock(ActivatedRoute);
 const mockedDialogService = mock(DialogService);
@@ -175,14 +173,13 @@
       { provide: ActivatedRoute, useMock: mockedActivatedRoute },
       { provide: UserService, useMock: mockedUserService },
       { provide: SFProjectService, useMock: mockedProjectService },
-      { provide: TranslationEngineService, useMock: mockedTranslationEngineService },
       { provide: NoticeService, useMock: mockedNoticeService },
       { provide: DialogService, useMock: mockedDialogService },
       { provide: QuestionDialogService, useMock: mockedQuestionDialogService },
       { provide: ChapterAudioDialogService, useMock: mockedChapterAudioDialogService },
       { provide: FileService, useMock: mockedFileService },
       { provide: OnlineStatusService, useClass: TestOnlineStatusService },
       provideNoopAnimations()
     ]
   }));
 
@@ -1392,15 +1389,10 @@
     it('saves the last visited question', fakeAsync(() => {
       const env = new TestEnvironment({ user: CHECKER_USER });
       const projectUserConfigDoc = env.component.projectUserConfigDoc!.data!;
-      verify(mockedTranslationEngineService.trainSelectedSegment(anything(), anything())).once();
       expect(projectUserConfigDoc.selectedQuestionRef).toBe('project01:q5Id');
-      env.component.projectDoc!.submitJson0Op(op => {
-        op.set<boolean>(p => p.translateConfig.translationSuggestionsEnabled, false);
-      });
       env.waitForSliderUpdate();
       env.selectQuestion(4);
       expect(projectUserConfigDoc.selectedQuestionRef).toBe('project01:q4Id');
-      verify(mockedTranslationEngineService.trainSelectedSegment(anything(), anything())).once();
     }));
 
     it('saves the last visited question in all question context', fakeAsync(() => {
@@ -1411,11 +1403,9 @@
         questionScope: 'all'
       });
       const projectUserConfigDoc = env.component.projectUserConfigDoc!.data!;
-      verify(mockedTranslationEngineService.trainSelectedSegment(anything(), anything())).once();
       expect(projectUserConfigDoc.selectedQuestionRef).toBe('project01:q5Id');
       env.selectQuestion(4);
       expect(projectUserConfigDoc.selectedQuestionRef).toBe('project01:q3Id');
-      verify(mockedTranslationEngineService.trainSelectedSegment(anything(), anything())).twice();
     }));
 
     it('can cancel answering a question', fakeAsync(() => {
@@ -3215,7 +3205,6 @@
         tag: TestEnvironment.project01WritingSystemTag
       },
       translateConfig: {
-        translationSuggestionsEnabled: true,
         source: {
           paratextId: 'project02',
           projectRef: 'project02',

src/SIL.XForge.Scripture/ClientApp/src/app/connect-project/connect-project.component.spec.ts

@@ -354,7 +354,6 @@ class TestEnvironment {
       const newProject: SFProject = createTestProject({
         paratextId: settings.paratextId,
         translateConfig: {
-          translationSuggestionsEnabled: false,
           source:
             settings.sourceParatextId == null
               ? undefined

src/SIL.XForge.Scripture/ClientApp/src/app/core/models/sf-project-settings.ts

@@ -4,7 +4,6 @@ import { CheckingAnswerExport } from 'realtime-server/lib/esm/scriptureforge/mod
  * This interface represents the project settings that can be updated using "SFProjectService.onlineUpdateSettings()".
  */
 export interface SFProjectSettings {
-  translationSuggestionsEnabled?: boolean | null;
   sourceParatextId?: string | null;
   biblicalTermsEnabled?: boolean | null;