SF-3882 Remove SMT Translation Suggestions - #4025
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4025 +/- ##
==========================================
- Coverage 81.04% 80.65% -0.40%
==========================================
Files 659 652 -7
Lines 42761 41242 -1519
Branches 6994 6787 -207
==========================================
- Hits 34657 33264 -1393
+ Misses 6960 6856 -104
+ Partials 1144 1122 -22 ☔ View full report in Codecov by Harness. |
|
📸 Screenshot diff deployed! (3 changes) View the visual diff at: https://pr-4025--sf-screenshot-diffs.netlify.app |
Nateowami
left a comment
There was a problem hiding this comment.
@Nateowami made 1 comment.
Reviewable status: 0 of 94 files reviewed, all discussions resolved.
src/RealtimeServer/scriptureforge/models/sf-project-user-config-test-data.ts line 13 at r2 (raw file):
confidenceThreshold: 0.2, transliterateBiblicalTerms: false, translationSuggestionsEnabled: false,
I'm surprised to see this property remains, rather than being migrated off.
|
(I guess I should state my actual question, which is whether this was a deliberate decision and why) |
This change is