Skip to content

SF-3882 Remove SMT Translation Suggestions - #4025

Open
pmachapman wants to merge 2 commits into
masterfrom
fix/SF-3882
Open

SF-3882 Remove SMT Translation Suggestions#4025
pmachapman wants to merge 2 commits into
masterfrom
fix/SF-3882

Conversation

@pmachapman

@pmachapman pmachapman commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

This change is Reviewable

@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.79811% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.65%. Comparing base (637ea89) to head (d173a5f).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...SIL.XForge.Scripture/Services/MachineApiService.cs 89.47% 3 Missing and 9 partials ⚠️
...slate/draft-generation/draft-generation.service.ts 33.33% 4 Missing ⚠️
...XForge.Scripture/Services/MachineProjectService.cs 97.08% 0 Missing and 4 partials ⚠️
.../SIL.XForge.Scripture/Services/SFProjectService.cs 66.66% 1 Missing and 1 partial ⚠️
...val-administration/job-details-dialog.component.ts 0.00% 1 Missing ⚠️
...e/ClientApp/src/app/settings/settings.component.ts 50.00% 0 Missing and 1 partial ⚠️
...ntApp/src/app/translate/editor/editor.component.ts 93.75% 1 Missing ⚠️
...XForge.Scripture/Services/PreTranslationService.cs 94.11% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4025      +/-   ##
==========================================
- Coverage   81.04%   80.65%   -0.40%     
==========================================
  Files         659      652       -7     
  Lines       42761    41242    -1519     
  Branches     6994     6787     -207     
==========================================
- Hits        34657    33264    -1393     
+ Misses       6960     6856     -104     
+ Partials     1144     1122      -22     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

📸 Screenshot diff deployed! (3 changes)

View the visual diff at: https://pr-4025--sf-screenshot-diffs.netlify.app

Comment thread src/SIL.XForge.Scripture/Services/MachineApiService.cs Fixed
Comment thread src/SIL.XForge.Scripture/Services/MachineProjectService.cs Fixed
Comment thread src/SIL.XForge.Scripture/Services/MachineProjectService.cs Fixed
Comment thread src/SIL.XForge.Scripture/Services/MachineProjectService.cs Fixed
Comment thread src/SIL.XForge.Scripture/Services/MachineProjectService.cs Fixed
Comment thread src/SIL.XForge.Scripture/Services/MachineProjectService.cs Fixed
Comment thread src/SIL.XForge.Scripture/Services/MachineProjectService.cs Fixed
@pmachapman pmachapman changed the title WIP: SF-3882 Remove SMT Translation Suggestions SF-3882 Remove SMT Translation Suggestions Aug 5, 2026
@pmachapman pmachapman added the will require testing PR should not be merged until testers confirm testing is complete label Aug 5, 2026
@pmachapman
pmachapman marked this pull request as ready for review August 5, 2026 00:52

@Nateowami Nateowami left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nateowami made 1 comment.
Reviewable status: 0 of 94 files reviewed, all discussions resolved.


src/RealtimeServer/scriptureforge/models/sf-project-user-config-test-data.ts line 13 at r2 (raw file):

    confidenceThreshold: 0.2,
    transliterateBiblicalTerms: false,
    translationSuggestionsEnabled: false,

I'm surprised to see this property remains, rather than being migrated off.

@Nateowami

Copy link
Copy Markdown
Collaborator

(I guess I should state my actual question, which is whether this was a deliberate decision and why)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

will require testing PR should not be merged until testers confirm testing is complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants